fix(insights): use getUserToken method instead of _get #4744
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f54eb10:
|
| @@ -86,25 +86,6 @@ describe('insights', () => { | |||
| }); | |||
|
|
|||
| describe('initialize', () => { | |||
| it('initialize insightsClient', () => { | |||
There was a problem hiding this comment.
This test is redundant. We do not need _hasCredentials anywhere in search-insights or InstantSearch.js. (The test may have been added to see the possibility of avoiding duplicated init calls, but it's taken care in another PR.)
eunjae-lee
requested review from
a team,
tkrugg and
shortcuts
and removed request for
a team
There was a problem hiding this comment.
do we need to check that the insights client is at least version 1.2.0? I'm not sure if it's possible, since there's no method to get the version. since that version is pretty old, I think it's ok to use it here
EDIT: question irrelevant, getUserToken is older than _get
* fix(insights): use getUserToken method instead of _get * fix test cases
Summary
This PR replaces
_getwithgetUserToken. At the time of writing the insights middleware, I wasn't aware ofgetUserTokenmethod.Result
It works the same.