feat(ts): migrate toggleRefinement & connectToggleRefinement #4743
+627
−522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
requested review from
a team,
eunjae-lee and
tkrugg
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d5d55d5:
|
Haroenv
force-pushed
the
chore/types-reorg-8
branch
3 times, most recently
from
52bb7f1 to
467df0e
Compare
eunjae-lee
approved these changes
Apr 29, 2021
Haroenv
force-pushed
the
feat/toggle-ts
branch
4 times, most recently
from
10a1064 to
822a934
Compare
tkrugg
reviewed
Apr 30, 2021
| }: { | ||
| isRefined: boolean; | ||
| } = { isRefined: false } | ||
| ) => { | ||
| if (!isRefined) { | ||
| sendEvent('click', isRefined); |
There was a problem hiding this comment.
I'm not super familiar with this but isn't we supposed to pass the attribute:{{value}} here ?
There was a problem hiding this comment.
let's not change it in this PR :)
tkrugg
approved these changes
Apr 30, 2021
Haroenv
force-pushed
the
chore/types-reorg-8
branch
from
467df0e to
11c6b97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
converts toggleRefinement and connectToggleRefinement
Result
toggleRefinement and connectToggleRefinement are converted to typescript
(note typescript will fail until this is rebased onto master, I didn't do it now because it's 9 PRs deep)