fix(infiniteHits): fix wrong behavior of showPrevious regarding cachedHits #4725
+48
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the wrong behavior of
showPrevious
andshowMore
because the functions were created atinit
withcachedHits
. It meansshowPrevious
andshowMore
always have wrong (empty)cachedHits
object. Instead, we need to read fromcache
every time.fixes algolia/vue-instantsearch#945
Reproduction of the issue from Vue InstantSearch
https://fyn4y.csb.app/?instant_search[page]=4 (https://codesandbox.io/s/instantsearchjs-forked-fyn4y?file=/src/app.js)
And the following is the same example with the InstantSearch.js version from this PR and it works fine:
https://tdmbd.csb.app/?instant_search[page]=4 (https://codesandbox.io/s/instantsearchjs-forked-tdmbd?file=/src/app.js)
Result
showPrevious
andshowMore
work correctly.