feat(ts): convert Template component to TypeScript #4703
Merged
+57
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannickcr
requested review from
a team,
eunjae-lee and
shortcuts
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e922cc2:
|
Haroenv
reviewed
Mar 30, 2021
Haroenv
reviewed
Mar 30, 2021
| templatesConfig: {}, | ||
| }); | ||
|
|
||
| class Template extends Component<TemplateProps> { |
There was a problem hiding this comment.
template should be generic with TData
There was a problem hiding this comment.
Tried it but I was not able to pass it without breaking everything 😞
I took another approach and used PreparedTemplateProps to create part of the props (but as a result TTemplateData is still set to any). We can work together on this to find a better solution if you want.
There was a problem hiding this comment.
we can iterate on this another time since the component is internal, possibly add a todo here?
Haroenv
reviewed
Apr 1, 2021
yannickcr
force-pushed
the
feat/ts-template
branch
from
018751f to
a7022eb
Compare
Haroenv
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converts the
Templatecomponent to TypeScript