feat(ts): convert RefinementList component to TypeScript #4702
+490
−297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannickcr
requested review from
a team,
eunjae-lee and
shortcuts
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 90dc9b9:
|
yannickcr
force-pushed
the
feat/ts-refinementlist
branch
from
e40a200 to
837dc73
Compare
Haroenv
reviewed
Mar 30, 2021
src/components/RefinementList/__tests__/RefinementListItem-test.tsx
Outdated
Show resolved
Hide resolved
src/components/RefinementList/__tests__/RefinementListItem-test.tsx
Outdated
Show resolved
Hide resolved
yannickcr
commented
Mar 31, 2021
Haroenv
reviewed
Apr 1, 2021
Haroenv
approved these changes
Apr 1, 2021
eunjae-lee
approved these changes
Apr 6, 2021
|
something here broke the RatingMenu component, will investigate! edit: unrelated after all #4728 |
Haroenv
added a commit
that referenced
this pull request
Jan 11, 2024
Handle the clicks in the RefinementList component (used by RatingMenu) when the clicked element isn't a `HTMLElement`. The fixed behaviour is fairly finicky to reproduce, you need to click exactly on the "star image", if you click between them or on the text, no issue existed before this PR either. The removed check was introduced in #4702, when translating the component to TypeScript. This implements a barebones CTS for RatingMenu, including being fully skipped for React InstantSearch, as the widget doesn't exist.
Haroenv
added a commit
that referenced
this pull request
Jan 16, 2024
* fix(RatingMenu): handle clicks in svg Handle the clicks in the RefinementList component (used by RatingMenu) when the clicked element isn't a `HTMLElement`. The fixed behaviour is fairly finicky to reproduce, you need to click exactly on the "star image", if you click between them or on the text, no issue existed before this PR either. The removed check was introduced in #4702, when translating the component to TypeScript. This implements a barebones CTS for RatingMenu, including being fully skipped for React InstantSearch, as the widget doesn't exist. * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converts the
RefinementListcomponent to TypeScript