feat(ts): convert sortBy, connectSortBy #4700
Merged
+421
−388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
requested review from
a team,
yannickcr and
eunjae-lee
and removed request for
a team
shortcuts
commented
Mar 29, 2021
Comment on lines
-109
to
-115
|
|
||
| it('sets the underlying index', () => { | ||
| widget.setIndex('index-b'); | ||
|
|
||
| expect(helper.setIndex).toHaveBeenCalledTimes(1); | ||
| expect(helper.search).toHaveBeenCalledTimes(1); | ||
| }); |
There was a problem hiding this comment.
Should this be possible? As we don't expose setIndex, I feel like this test isn't needed
There was a problem hiding this comment.
it should be calling getWidgetRenderState().refine for an equivalent test
There was a problem hiding this comment.
however it makes sense that this is tested in the connector alone
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0d11ab8:
|
Haroenv
reviewed
Mar 29, 2021
Haroenv
reviewed
Mar 30, 2021
Haroenv
reviewed
Mar 30, 2021
Haroenv
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert
sortBy,connectSortByto TypeScript