feat(ratingMenu): implement canRefine #4691
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
changed the title
eunjae-lee
requested review from
a team,
Haroenv and
shortcuts
and removed request for
a team
eunjae-lee
force-pushed
the
feat/canrefine-rating-menu
branch
from
205772f to
29b684b
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8d0c9a5:
|
Haroenv
reviewed
Mar 23, 2021
| @@ -327,6 +328,7 @@ ${ | |||
| return { | |||
| items: facetValues, | |||
| hasNoResults: results ? results.nbHits === 0 : true, | |||
| canRefine: Boolean(results && results.nbHits > 0), | |||
There was a problem hiding this comment.
instead it should be facetValues.length > 1 I think
There was a problem hiding this comment.
I think I'm missing somehting.
Isn't canRefine supposed to be on the item level?
My understanding was: canRefine tells you whether you can click (i.e. call refine) on a specific item.
There was a problem hiding this comment.
it's meant for if you can refine the whole widget, every item can be refined normally
Haroenv
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
implements canRefine in connectRatingMenu as true when nbHits > 0.
DX-1308
Result
ratingMenu now has a canRefine