feat(toggleRefinement): implement canRefine #4689
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 846a826:
|
| @@ -306,6 +307,7 @@ export default function connectToggleRefinement(renderFn, unmountFn = noop) { | |||
| createURL, | |||
| }), | |||
| sendEvent, | |||
| canRefine: Boolean(results ? nextRefinement.count : null), | |||
There was a problem hiding this comment.
I'm not sure what condition it should be here. Maybe to be false, but current refinement and next refinement should have a 0 count? I'm not sure!
There was a problem hiding this comment.
This condition is actually coming from Vue InstantSearch
const mapStateToCanRefine = state => Boolean(state.value && state.value.count);and state.value is made in InstantSearch.js like this:
value: {
name: attribute,
isRefined,
count: results ? nextRefinement.count : null,
onFacetValue,
offFacetValue,
},I'm not too sure either, but it'd be good to align between InstantSearch.js and Vue InstantSearch first, and then later change to something else if needed from the InstantSearch.js and propagate to Vue InstantSearch. What do you think?
Summary
implements canRefine in connectToggleRefinement as true when there value.count exists.
DX-1309
Result
toggleRefinement now has a canRefine