feat(ts): convert connectRefinementList, refinementList #4658
+1,780
−1,511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Haroenv
commented
Feb 19, 2021
Haroenv
commented
- changed how the searchbox templates are done to be easier to type and code
- did not migrate RefinementList component
- moved prepareTemplateProps tests
- fixed a typo in prepareTemplateProps tests
Haroenv
commented
Feb 19, 2021
| it('should return the default templates and set useCustomCompileOptions to false when using the defaults', () => { | ||
| const defaultsPrepared = prepareTemplateProps({ | ||
| defaultTemplates, | ||
| templates: undefined, |
There was a problem hiding this comment.
this line is the only change I made when translating the test
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f2f7752:
|
Haroenv
requested review from
shortcuts,
yannickcr,
francoischalifour and
eunjae-lee
- changed how the searchbox templates are done to be easier to type and code - did not migrate RefinementList component - moved prepareTemplateProps tests - fixed a typo in prepareTemplateProps tests
Haroenv
force-pushed
the
feat/refinementList-ts
branch
from
cc4eac6 to
88f2f13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.