Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts): update to typescript 4 #4654

Merged
merged 17 commits into from
Mar 11, 2021
Merged

feat(ts): update to typescript 4 #4654

merged 17 commits into from
Mar 11, 2021

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Feb 16, 2021

  • replace all ts-ignore by ts-expect-error
  • remove ignores that were no longer needed
  • make ignored imports work more efficiently
  • update typescript-eslint (because it was needed)
  • fix all errors marked by typescript-eslint
  • algoliasearch v3 interop without eslint disables

this isn't a breaking change, since it only changes typescript, but worth considering

Verified

This commit was signed with the committer’s verified signature.
edolstra Eelco Dolstra
- replace all ts-ignore by ts-expect-error
- remove ignores that were no longer needed
- make ignored imports work more efficiently
@Haroenv Haroenv requested review from a team, yannickcr and eunjae-lee and removed request for a team February 16, 2021 17:32
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 16, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aad51f3:

Sandbox Source
InstantSearch.js Configuration

Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Haroenv Haroenv requested a review from yannickcr March 9, 2021 09:18
Copy link
Contributor

@yannickcr yannickcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Haroenv Haroenv merged commit 638e437 into master Mar 11, 2021
@Haroenv Haroenv deleted the chore/ts-4 branch March 11, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants