.codesandbox/ci.json

@@ -1,4 +1,4 @@
 {
   "sandboxes": ["instantsearchjs-es-template-pcw1k"],
-  "buildCommand": "build:es"
+  "buildCommand": "build"
 }

.eslintrc.js

@@ -62,6 +62,25 @@ module.exports = {
         '@typescript-eslint/no-redeclare': ['error'],
       },
     },
+    {
+      files: ['*.ts', '*.tsx'],
+      // this is the same files as ignored in tsconfig.json
+      excludedFiles: [
+        "examples/**/*",
+        "es",
+        // these two files are temporarily excluded because
+        // they import files from node_modules/search-insights directly
+        // and it causes the type-checking to fail.
+        "src/middlewares/__tests__/createInsightsMiddleware.ts",
+        "test/mock/createInsightsClient.ts"
+      ],
+      parserOptions: {
+        project: './tsconfig.json',
+      },
+      rules: {
+        '@typescript-eslint/no-unnecessary-type-assertion': 'error',
+      },
+    },
     {
       files: ['*.js'],
       rules: {

CHANGELOG.md

@@ -1,3 +1,18 @@
+# [4.28.0](https://github.com/algolia/instantsearch.js/compare/v4.27.2...v4.28.0) (2021-08-24)
+
+
+### Bug Fixes
+
+* **sendEvent:** split > 20 objects in multiple calls ([#4841](https://github.com/algolia/instantsearch.js/issues/4841)) ([44574bc](https://github.com/algolia/instantsearch.js/commit/44574bcf03ac05e22274099622e6a1839599ca7e))
+* **svg:** remove xmlns ([#4839](https://github.com/algolia/instantsearch.js/issues/4839)) ([932ae3a](https://github.com/algolia/instantsearch.js/commit/932ae3a868340a32ccaacb276c862921fee41a93))
+
+
+### Features
+
+* **ts:** expose built files in umd ([#4844](https://github.com/algolia/instantsearch.js/issues/4844)) ([8578ae3](https://github.com/algolia/instantsearch.js/commit/8578ae30a915db49acaa0292faba2ec6ccd52b73))
+
+
+
 ## [4.27.2](https://github.com/algolia/instantsearch.js/compare/v4.27.1...v4.27.2) (2021-08-18)
 
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "instantsearch.js",
-  "version": "4.27.2",
+  "version": "4.28.0",
   "description": "InstantSearch.js is a JavaScript library for building performant and instant search experiences with Algolia.",
   "homepage": "https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/js/",
   "types": "es/index.d.ts",

scripts/typescript/api-extractor.json

@@ -6,7 +6,8 @@
   "mainEntryPointFilePath": "<projectFolder>/es/index.d.ts",
 
   "dtsRollup": {
-    "enabled": false
+    "enabled": true,
+    "untrimmedFilePath": "<projectFolder>/dist/instantsearch.production.d.ts"
   },
 
   "apiReport": {

scripts/typescript/extract.js

@@ -19,12 +19,6 @@ shell.sed(
   path.join(__dirname, '../../es/**/*.d.ts')
 );
 
-// expose only the es entry point, not the umd entry point
-shell.mv(
-  path.join(__dirname, '../../es/index.es.d.ts'),
-  path.join(__dirname, '../../es/index.d.ts')
-);
-
 console.log();
 console.log(`Validating definitions...`);
 
@@ -47,3 +41,24 @@ if (!result.succeeded) {
 
   process.exitCode = 1;
 }
+
+// move the right entry points
+// esm to override umd
+shell.mv(
+  path.join(__dirname, '../../es/index.es.d.ts'),
+  path.join(__dirname, '../../es/index.d.ts')
+);
+
+// production and development umd
+shell.cp(
+  path.join(__dirname, '../../dist/instantsearch.production.d.ts'),
+  path.join(__dirname, '../../dist/instantsearch.production.min.d.ts')
+);
+shell.cp(
+  path.join(__dirname, '../../dist/instantsearch.production.d.ts'),
+  path.join(__dirname, '../../dist/instantsearch.development.d.ts')
+);
+shell.cp(
+  path.join(__dirname, '../../dist/instantsearch.production.d.ts'),
+  path.join(__dirname, '../../dist/instantsearch.development.min.d.ts')
+);

src/components/Panel/Panel.tsx

@@ -40,14 +40,15 @@ function Panel<TWidget extends UnknownWidgetFactory>(
   const bodyRef = useRef<HTMLElement | null>(null);
 
   useEffect(() => {
-    if (!bodyRef.current) {
+    const node = bodyRef.current;
+    if (!node) {
       return undefined;
     }
 
-    bodyRef.current.appendChild(props.bodyElement);
+    node.appendChild(props.bodyElement);
 
     return () => {
-      bodyRef!.current!.removeChild(props.bodyElement);
+      node.removeChild(props.bodyElement);
     };
   }, [bodyRef, props.bodyElement]);
 

src/components/Slider/Rheostat.tsx

@@ -303,7 +303,7 @@ class Rheostat extends Component<Props, State> {
     if (!this.props.snapPoints!.length) return value;
 
     return this.props.snapPoints!.reduce((snapTo, snap) =>
-      Math.abs(snapTo! - value) < Math.abs(snap - value) ? snapTo : snap
+      Math.abs(snapTo - value) < Math.abs(snap - value) ? snapTo : snap
     );
   }
 

src/connectors/answers/connectAnswers.ts

@@ -146,7 +146,7 @@ const connectAnswers: AnswersConnector = function connectAnswers(
 
       init(initOptions) {
         const { state, instantSearchInstance } = initOptions;
-        const answersIndex = instantSearchInstance.client!.initIndex!(
+        const answersIndex = instantSearchInstance.client.initIndex!(
           state.index
         );
         if (!hasFindAnswersMethod(answersIndex)) {

src/connectors/autocomplete/__tests__/connectAutocomplete-test.ts

@@ -556,7 +556,7 @@ search.addWidgets([
     test('should give back the object unmodified if the default value is selected', () => {
       const [widget, helper] = getInitializedWidget();
       const uiStateBefore = {};
-      const uiStateAfter = widget.getWidgetUiState!(uiStateBefore, {
+      const uiStateAfter = widget.getWidgetUiState(uiStateBefore, {
         searchParameters: helper.state,
         helper,
       });
@@ -567,7 +567,7 @@ search.addWidgets([
       const [widget, helper, refine] = getInitializedWidget();
       refine('some query');
       const uiStateBefore = {};
-      const uiStateAfter = widget.getWidgetUiState!(uiStateBefore, {
+      const uiStateAfter = widget.getWidgetUiState(uiStateBefore, {
         searchParameters: helper.state,
         helper,
       });
@@ -579,14 +579,14 @@ search.addWidgets([
     test('should give back the same instance if the value is already in the uiState', () => {
       const [widget, helper, refine] = getInitializedWidget();
       refine('query');
-      const uiStateBefore = widget.getWidgetUiState!(
+      const uiStateBefore = widget.getWidgetUiState(
         {},
         {
           searchParameters: helper.state,
           helper,
         }
       );
-      const uiStateAfter = widget.getWidgetUiState!(uiStateBefore, {
+      const uiStateAfter = widget.getWidgetUiState(uiStateBefore, {
         searchParameters: helper.state,
         helper,
       });
@@ -604,7 +604,7 @@ search.addWidgets([
         })
       );
 
-      const actual = widget.getWidgetSearchParameters!(helper.state, {
+      const actual = widget.getWidgetSearchParameters(helper.state, {
         uiState: {
           query: 'Apple',
         },
@@ -628,7 +628,7 @@ search.addWidgets([
         })
       );
 
-      const actual = widget.getWidgetSearchParameters!(helper.state, {
+      const actual = widget.getWidgetSearchParameters(helper.state, {
         uiState: {},
       });
 
@@ -652,7 +652,7 @@ search.addWidgets([
         })
       );
 
-      const actual = widget.getWidgetSearchParameters!(helper.state, {
+      const actual = widget.getWidgetSearchParameters(helper.state, {
         uiState: {},
       });
 
@@ -676,7 +676,7 @@ search.addWidgets([
         })
       );
 
-      const actual = widget.getWidgetSearchParameters!(helper.state, {
+      const actual = widget.getWidgetSearchParameters(helper.state, {
         uiState: {},
       });
 

src/connectors/autocomplete/connectAutocomplete.ts

@@ -176,7 +176,7 @@ search.addWidgets([
           const sendEvent = createSendEventForHits({
             instantSearchInstance,
             index: scopedResult.results.index,
-            widgetType: this.$$type!,
+            widgetType: this.$$type,
           });
 
           return {
@@ -191,7 +191,7 @@ search.addWidgets([
         return {
           currentRefinement: helper.state.query || '',
           indices,
-          refine: connectorState.refine!,
+          refine: connectorState.refine,
           widgetParams,
         };
       },