Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: algolia/instantsearch
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.27.1
Choose a base ref
...
head repository: algolia/instantsearch
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.27.2
Choose a head ref
  • 3 commits
  • 308 files changed
  • 2 contributors

Commits on Aug 18, 2021

  1. chore(prettier): update version (#4836)

    * chore(prettier): update version
    
    main changes are around parens
    
    * fix lint
    
    * more lint fix somehow
    Haroenv authored Aug 18, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    6e62930 View commit details
  2. fix(types): export all types as "type" to avoid exporting in .js (#4837)

    * fix(types): export all types as "type" to avoid exporting in .js
    
    This issue is caused by `export * from './types'` added in #4834, which causes everything in /types to be exposed, but unfortunately because `export from` in the InstantSearch file mixed a type and a value, and thus exported it.
    
    This is done by enabling [consistent-type-imports](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/consistent-type-imports.md) in eslint to make sure it's correct in all cases
    
    references:
    - code that throws: https://unpkg.com/browse/instantsearch.js@4.27.1/es/types/instantsearch.js
    - vite reproduction: https://github.com/eunjae-lee/vue-instantsearch-with-vue3-and-vite
    
    * fix ts
    
    * chore(ts): also enable `isolatedModules`
    
    this catches when you export something that's a type as a regular export, further avoiding the issue
    Haroenv authored Aug 18, 2021
    Copy the full SHA
    dcbbd88 View commit details
  3. chore: release v4.27.2 (#4838)

    * chore: release v4.27.2
    
    * Update CHANGELOG.md
    
    Co-authored-by: Haroen Viaene <hello@haroen.me>
    instantsearch-bot and Haroenv authored Aug 18, 2021
    Copy the full SHA
    413c2db View commit details
Loading