-
Notifications
You must be signed in to change notification settings - Fork 532
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: algolia/instantsearch
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.25.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: algolia/instantsearch
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.26.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 7 commits
- 29 files changed
- 3 contributors
Commits on Aug 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 585e38f - Browse repository at this point
Copy the full SHA 585e38fView commit details -
feat(ts): allow custom ui state and route state in routing (#4816)
* feat(ts): allow custom ui state and route state in routing While I couldn't find a way to make InstantSearch itself generic (this gets passed to many places, which then loses generic), using the routing middleware directly is possible like this now ```ts import instantsearch from 'instantsearch.js/es' import { history } from 'instantsearch.js/es/lib/routers'; import { createRouterMiddleware } from 'instantsearch.js/es/middlewares'; import { StateMapping, UiState } from 'instantsearch.js/es/types'; type SwagIndexUiState = { swag: boolean }; type SwagUiState = { [indexName: string]: SwagIndexUiState }; const stateMapping: StateMapping<UiState & SwagUiState, SwagUiState> = { stateToRoute(uiState) { return Object.keys(uiState).reduce( (state, indexId) => ({ ...state, [indexId]: { swag: uiState[indexId].swag }, }), {} ); }, routeToState(routeState = {}) { return Object.keys(routeState).reduce( (state, indexId) => ({ ...state, [indexId]: routeState[indexId], }), {} ); }, }; const search = instantsearch(); search.use( createRouterMiddleware<UiState & SwagUiState, SwagUiState>({ router: history(), stateMapping, }) ); search.addWidgets([instantsearch.widgets.hits({ container })]); ``` * actually genericificate InstantSearch * already inferred so no need * Apply suggestions from code review * address feedback * better comment
Configuration menu - View commit details
-
Copy full SHA for 5f8ba5d - Browse repository at this point
Copy the full SHA 5f8ba5dView commit details -
an example of how it's different is: ```ts import { Expand, UiState } from './types'; type mix = UiState & { [index: string]: { swag?: boolean } }; type mixExpand = Expand<mix>; // @ts-expect-error const initialUiState: mix = { someIndex: { swag: true, }, }; const initialUiStateExpanded: mixExpand = { someIndex: { swag: true, }, }; ```
Configuration menu - View commit details
-
Copy full SHA for fb0088a - Browse repository at this point
Copy the full SHA fb0088aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1de0c75 - Browse repository at this point
Copy the full SHA 1de0c75View commit details
Commits on Aug 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 362fb0f - Browse repository at this point
Copy the full SHA 362fb0fView commit details -
feat(types): allow typed access to properties added to entry (#4814)
also removes the file for "main" as it's inconsistent with index.es.ts
Configuration menu - View commit details
-
Copy full SHA for 9000f16 - Browse repository at this point
Copy the full SHA 9000f16View commit details
Commits on Aug 12, 2021
-
chore: release v4.26.0 (#4828)
* chore: release v4.26.0 * Update CHANGELOG.md Co-authored-by: Haroen Viaene <hello@haroen.me>
Configuration menu - View commit details
-
Copy full SHA for 1450e85 - Browse repository at this point
Copy the full SHA 1450e85View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v4.25.3...v4.26.0