Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: algolia/instantsearch
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.25.2
Choose a base ref
...
head repository: algolia/instantsearch
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.25.3
Choose a head ref
  • 3 commits
  • 33 files changed
  • 4 contributors

Commits on Jul 30, 2021

  1. chore(ts): avoid more ts-ignores (#4817)

    ts-expect-error will error if it's no longer needed, so it's better in almost all cases. There's some moments where we need to keep ts-ignore though:
    - things that fail only with algoliasearch v3 or v4
    - optional packages (places)
    - code that doesn't always error
    
    At the same time updated the algoliasearch-helper to a version that includes `showParentLevel` in the typings
    Haroenv authored Jul 30, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    21b6c53 View commit details

Commits on Aug 3, 2021

  1. fix(types): fixing hits and results types in connectHits and connectI…

    …nfiniteHits (#4820)
    
    * fix(types): change results type to use Hit instead of AlgoliaHits
    
    The types Hit and AlgoliaHit are mostly the same.
    
    type Hit = {
      __position: number;
      __queryID?: string;
    } & AlgoliaHit;
    
    source: https://github.com/algolia/instantsearch.js/blob/21b6c53d4b1a3f3dd3a2375a5cfe0a31bef6ded6/src/types/results.ts#L60-L63
    
    As of today, the hits exposed via results indeed [contain __position and
    __queryID](https://github.com/algolia/instantsearch.js/blob/21b6c53d4b1a3f3dd3a2375a5cfe0a31bef6ded6/src/connectors/hits/connectHits.ts#L158).
    
    * fix(types): add `hits` and `results` to `InfiniteHitsRenderState`
    
    While trying use `InfiniteHitsRenderState` in Angular InstantSearch I
    noticed how `hits` and `results` while being [part of the state expored
    by
    `connectInfiniteHits`](https://github.com/algolia/instantsearch.js/blob/master/src/connectors/infinite-hits/connectInfiniteHits.ts#L331-L342)
    are not actually visible on the type.
    tkrugg authored Aug 3, 2021
    Copy the full SHA
    2bf987e View commit details
  2. chore: release v4.25.3 (#4823)

    * chore: release v4.25.3
    
    * Update CHANGELOG.md
    
    Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>
    
    Co-authored-by: Haroen Viaene <hello@haroen.me>
    Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>
    3 people authored Aug 3, 2021
    Copy the full SHA
    598a27b View commit details
Loading