Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: algolia/instantsearch
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.20.0
Choose a base ref
...
head repository: algolia/instantsearch
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.21.0
Choose a head ref
  • 12 commits
  • 53 files changed
  • 3 contributors

Commits on Apr 6, 2021

  1. feat(middleware): accept partial methods (#4673) 

    * fix(middleware): accept partial methods

* make public api optional, not the internal one

* rename the types

* ensure at least one method is given to a middleware

* fix lint error
    Eunjae Lee authored Apr 6, 2021
    Copy the full SHA
    8f2aad2 View commit details

  2. feat(ts): convert search-box to TypeScript (#4710) 

    * feat(ts): convert search-box to TypeScript

* Apply suggestions from code review

Co-authored-by: Haroen Viaene <hello@haroen.me>

* fixup! feat(ts): convert search-box to TypeScript

* fixup! feat(ts): convert search-box to TypeScript

* fixup! feat(ts): convert search-box to TypeScript

Co-authored-by: Haroen Viaene <hello@haroen.me>
    @Haroenv
    Yannick Croissant and Haroenv authored Apr 6, 2021
    Copy the full SHA
    e73257a View commit details

  3. feat(ts): convert RefinementList component to TypeScript (#4702) 

    * feat(ts): convert rating-menu to TypeScript

* feat(ts): convert RefinementList to TypeScript

* fixup! feat(ts): convert RefinementList to TypeScript

* fixup! feat(ts): convert RefinementList to TypeScript

* fixup! fixup! feat(ts): convert RefinementList to TypeScript

* Update src/components/RefinementList/RefinementList.tsx

Co-authored-by: Haroen Viaene <hello@haroen.me>

* fixup! feat(ts): convert RefinementList to TypeScript

* fixup! feat(ts): convert RefinementList to TypeScript

Co-authored-by: Haroen Viaene <hello@haroen.me>
    @Haroenv
    Yannick Croissant and Haroenv authored Apr 6, 2021
    Copy the full SHA
    fd562de View commit details

  4. chore(ts): fix type

    @Haroenv
    Haroenv committed Apr 6, 2021
    Copy the full SHA
    1d0d87c View commit details

Commits on Apr 8, 2021

  1. fix(infiniteHits): fix wrong behavior of showPrevious regarding cache… 

    …dHits (#4725)
    Eunjae Lee authored Apr 8, 2021
    Copy the full SHA
    40b27b6 View commit details

  2. feat(ts): convert hierarchical-menu to TypeScript (#4711) 

    * feat(ts): convert rating-menu to TypeScript

* feat(ts): convert RefinementList to TypeScript

* fixup! feat(ts): convert RefinementList to TypeScript

* fixup! feat(ts): convert RefinementList to TypeScript

* fixup! fixup! feat(ts): convert RefinementList to TypeScript

* Update src/components/RefinementList/RefinementList.tsx

Co-authored-by: Haroen Viaene <hello@haroen.me>

* fixup! feat(ts): convert RefinementList to TypeScript

* fixup! feat(ts): convert RefinementList to TypeScript

* feat(ts): convert hierarchical-menu to TypeScript

* Apply suggestions from code review

Co-authored-by: Haroen Viaene <hello@haroen.me>

* fixup! feat(ts): convert hierarchical-menu to TypeScript

* avoid casting

* deduplicate

Co-authored-by: Haroen Viaene <hello@haroen.me>
    @Haroenv
    Yannick Croissant and Haroenv authored Apr 8, 2021
    Copy the full SHA
    870e2f7 View commit details

  3. chore(ci): consistent modern yarn version (#4726) 

    So we have these packages in our package.json as devDependencies:

    "algoliasearch": "4.8.6",
    "algoliasearch-v3": "npm:algoliasearch@3.35.1",

This works fine for most use cases, when we import the package as "algoliasearch-v3" it resolves as expected to v3. However we also have another package depending itself on 3.35.1 in devDeps too:

    "places.js": "1.17.1",

It has 3.35.1 as dependency:

    "algoliasearch": "^3.35.1",

And thus imports it as "algoliasearch".

This worked fine and i have this in yarn.lock:

    "algoliasearch-v3@npm:algoliasearch@3.35.1":
      name algoliasearch-v3
      version "3.35.1"
      ...

    algoliasearch@^3.35.1:
      version "3.35.1"
      ...

    algoliasearch@4.8.6:
      version "4.8.6"
      ...

However now when i add any package (or yarn --force), it changes yarn.lock to this:

    "algoliasearch-v3@npm:algoliasearch@3.35.1", algoliasearch@^3.35.1:
      version "3.35.1"
      ...

    algoliasearch@4.8.6:
      version "4.8.6"
      ...

This seems fine, although the node_modules folder created for that is node_modules/algoliasearch-v3 alone, inside node_modules/places.js there's no other node_modules for the algoliasearch with the right name.

This can be tried out in the master branch by running yarn (right node_modules, with a algoliasearch inside places.js), and then failing by running yarn --force. when you're on yarn 1.13 like the netlify setup.

Co-authored-by: Eunjae Lee <eunjae.lee@algolia.com>
    @Haroenv
    Haroenv and Eunjae Lee authored Apr 8, 2021
    Copy the full SHA
    449aed3 View commit details

  4. Revert "chore(ci): consistent modern yarn version (#4726)" 

    This reverts commit 449aed3.
    @Haroenv
    Haroenv committed Apr 8, 2021
    Copy the full SHA
    e016b73 View commit details

  5. chore(ci): force compatible places/algoliasearch version 

    replaces #4726
    @Haroenv
    Haroenv committed Apr 8, 2021
    Copy the full SHA
    021dcbd View commit details

  6. chore(ts): convert voice search default templates (#4727)

    @Haroenv
    Haroenv authored Apr 8, 2021
    Copy the full SHA
    a894069 View commit details

Commits on Apr 9, 2021

  1. fix(ratingMenu): use url in default template (#4728) 

    this is the cause of the from time to time failing e2e test, basically sometimes the event.preventDefault didn't apply, which causes the page to refresh to / instead of the right url.

The actual url is `url`, and not in `href`, so this means that before now it always was wrong
    @Haroenv
    Haroenv authored Apr 9, 2021
    Copy the full SHA
    31d9c50 View commit details

Commits on Apr 12, 2021

  1. chore: release v4.21.0 (#4730) 

    * chore: release v4.21.0

* Update CHANGELOG.md
    @Haroenv
    Haroenv authored Apr 12, 2021
    Copy the full SHA
    e3a4398 View commit details
Showing with 149,670 additions and 1,335 deletions.
  1. +147,392 −0 .yarn/releases/yarn-1.22.10.cjs
  2. +5 −0 .yarnrc
  3. +18 −0 CHANGELOG.md
  4. +1 −1 examples/e-commerce/src/widgets/Ratings.ts
  5. +4 −1 package.json
  6. +159 −110 src/components/RefinementList/{RefinementList.js → RefinementList.tsx}
  7. +16 −13 src/components/RefinementList/{RefinementListItem.js → RefinementListItem.tsx}
  8. +285 −131 src/components/RefinementList/__tests__/{RefinementList-test.js → RefinementList-test.tsx}
  9. +12 −6 src/components/RefinementList/__tests__/{RefinementListItem-test.js → RefinementListItem-test.tsx}
  10. 0 ...finementList/__tests__/__snapshots__/{RefinementList-test.js.snap → RefinementList-test.tsx.snap}
  11. 0 ...List/__tests__/__snapshots__/{RefinementListItem-test.js.snap → RefinementListItem-test.tsx.snap}
  12. +0 −7 src/components/RefinementList/types.ts
  13. +74 −62 src/components/SearchBox/{SearchBox.js → SearchBox.tsx}
  14. +40 −33 src/components/SearchBox/__tests__/{SearchBox-test.js → SearchBox-test.tsx}
  15. 0 src/components/SearchBox/__tests__/__snapshots__/{SearchBox-test.js.snap → SearchBox-test.tsx.snap}
  16. +156 −110 ...s/hierarchical-menu/__tests__/{connectHierarchicalMenu-test.js → connectHierarchicalMenu-test.ts}
  17. +191 −86 src/connectors/hierarchical-menu/{connectHierarchicalMenu.js → connectHierarchicalMenu.ts}
  18. +32 −0 src/connectors/infinite-hits/__tests__/connectInfiniteHits-test.ts
  19. +16 −12 src/connectors/infinite-hits/connectInfiniteHits.ts
  20. +4 −0 src/connectors/refinement-list/connectRefinementList.ts
  21. +65 −51 src/connectors/search-box/__tests__/{connectSearchBox-test.js → connectSearchBox-test.ts}
  22. +53 −48 src/connectors/search-box/{connectSearchBox.js → connectSearchBox.ts}
  23. +6 −1 src/lib/InstantSearch.ts
  24. +14 −0 src/lib/__tests__/InstantSearch-test.js
  25. +1 −1 src/lib/version.ts
  26. +4 −2 src/middlewares/createInsightsMiddleware.ts
  27. +2 −2 src/middlewares/createMetadataMiddleware.ts
  28. +2 −2 src/middlewares/createRouterMiddleware.ts
  29. +8 −1 src/types/middleware.ts
  30. +6 −0 src/types/utils.ts
  31. +6 −20 src/types/widget.ts
  32. +32 −8 ...al-menu/__tests__/__snapshots__/{hierarchical-menu-test.js.snap → hierarchical-menu-test.ts.snap}
  33. +0 −221 src/widgets/hierarchical-menu/__tests__/hierarchical-menu-test.js
  34. +297 −0 src/widgets/hierarchical-menu/__tests__/hierarchical-menu-test.ts
  35. 0 src/widgets/hierarchical-menu/{defaultTemplates.js → defaultTemplates.ts}
  36. +180 −66 src/widgets/hierarchical-menu/{hierarchical-menu.js → hierarchical-menu.tsx}
  37. +16 −6 src/widgets/numeric-menu/__tests__/numeric-menu-test.ts
  38. +7 −1 src/widgets/numeric-menu/numeric-menu.tsx
  39. +1 −1 src/widgets/rating-menu/__tests__/__snapshots__/rating-menu-test.ts.snap
  40. +118 −0 src/widgets/rating-menu/__tests__/rating-menu-integration-test.ts
  41. +11 −11 src/widgets/rating-menu/__tests__/rating-menu-test.ts
  42. +1 −1 src/widgets/rating-menu/defaultTemplates.ts
  43. +5 −1 src/widgets/rating-menu/rating-menu.tsx
  44. +35 −24 src/widgets/refinement-list/refinement-list.tsx
  45. 0 src/widgets/search-box/__tests__/__snapshots__/{search-box-test.js.snap → search-box-test.ts.snap}
  46. +0 −101 src/widgets/search-box/__tests__/search-box-test.js
  47. +130 −0 src/widgets/search-box/__tests__/search-box-test.ts
  48. 0 src/widgets/search-box/{defaultTemplates.js → defaultTemplates.ts}
  49. +0 −167 src/widgets/search-box/search-box.js
  50. +251 −0 src/widgets/search-box/search-box.tsx
  51. +0 −20 src/widgets/search-box/types.ts
  52. +10 −2 src/widgets/voice-search/{defaultTemplates.js → defaultTemplates.ts}
  53. +4 −5 yarn.lock
Loading