fix(ts): make template types consistent (#4785)

* fix(ts): make templates types consistent

* fix: `Answers` type naming

* fix: remove `ComponentTemplates` type utils

* fix: remove unneeded comment

* fix: inline `searchBoxTemplateProps` templates

* fix: remove unneeded casts

* fix: move internal type to widget file

* rename template component type to `RefinementListComponentTemplates`

* fix: make `searchableNoResults` optional

* fix: remove unneeded default template

* fix: type `defaultTemplates`

* fix: apply changes from suggestion

Co-authored-by: Haroen Viaene <hello@haroen.me>

Author: shortcuts

src/components/Answers/Answers.tsx

@@ -9,15 +9,17 @@ import {
 } from '../../widgets/answers/answers';
 import { ComponentCSSClasses, Hits } from '../../types';
 
-export type AnswerComponentCSSClasses = ComponentCSSClasses<AnswersCSSClasses>;
+export type AnswersComponentCSSClasses = ComponentCSSClasses<AnswersCSSClasses>;
+
+export type AnswersComponentTemplates = Required<AnswersTemplates>;
 
 export type AnswersProps = {
   hits: Hits;
   isLoading: boolean;
-  cssClasses: AnswerComponentCSSClasses;
+  cssClasses: AnswersComponentCSSClasses;
   templateProps: {
     [key: string]: any;
-    templates: AnswersTemplates;
+    templates: AnswersComponentTemplates;
   };
 };
 

src/components/Breadcrumb/Breadcrumb.tsx

@@ -3,7 +3,10 @@
 import { h } from 'preact';
 import cx from 'classnames';
 import Template from '../Template/Template';
-import { BreadcrumbCSSClasses } from '../../widgets/breadcrumb/breadcrumb';
+import {
+  BreadcrumbCSSClasses,
+  BreadcrumbTemplates,
+} from '../../widgets/breadcrumb/breadcrumb';
 import { ComponentCSSClasses } from '../../types';
 
 type BreadcrumbItem = {
@@ -15,16 +18,13 @@ export type BreadcrumbComponentCSSClasses = ComponentCSSClasses<
   BreadcrumbCSSClasses
 >;
 
-type BreadcrumbTemplates = {
-  home: string;
-  separator: string;
-};
+export type BreadcrumbComponentTemplates = Required<BreadcrumbTemplates>;
 
 export type BreadcrumbProps = {
   items: BreadcrumbItem[];
   cssClasses: BreadcrumbComponentCSSClasses;
   templateProps: {
-    templates: BreadcrumbTemplates;
+    templates: BreadcrumbComponentTemplates;
   };
   createURL(value: string | undefined): string;
   refine(value: string | undefined): void;