Skip to content

Commit b37e23b

Browse files
tkruggHaroenv
andauthoredJul 16, 2021
fix(build): ensure build fails when types building fails (#4812)
* fix(build): ensure build fails when types building fails * Apply suggestions from code review Co-authored-by: Haroen Viaene <hello@haroen.me> * Update scripts/release/build-experimental-typescript.js Co-authored-by: Haroen Viaene <hello@haroen.me>
1 parent 3644799 commit b37e23b

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed
 

‎scripts/release/build-experimental-typescript.js

+8-2
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,11 @@ fs.writeFileSync(
1919
`export default '${newVersion}';\n`
2020
);
2121

22-
shell.exec(`NODE_ENV=production VERSION=${newVersion} yarn build`);
23-
shell.exec('yarn build:types');
22+
const results = [
23+
shell.exec(`NODE_ENV=production VERSION=${newVersion} yarn build`),
24+
shell.exec('yarn build:types'),
25+
];
26+
27+
if (results.some(({ code }) => code !== 0)) {
28+
shell.exit(1);
29+
}

0 commit comments

Comments
 (0)
Please sign in to comment.