feat(ts): update to typescript 4 (#4654)

* feat(ts): update to typescript 4

- replace all ts-ignore by ts-expect-error
- remove ignores that were no longer needed
- make ignored imports work more efficiently

* fix(ts): use inferred type for search client

* fix(ts): keep comments on imports

* chore(ci): update linting dependencies

* chore(lint): add dep

* chore(ts): make all lint rules pass

* chore(tsc): fix nits

* chore(ts): nicer v3 interop

* consistent naming

* chore: improve types

* chore: update test

* chore(e2e): undo free shipping change

* chore: avoid global

* chore: avoid ignore

* chore: avoid {}

* chore: avoid ignores

Author: Haroenv

.eslintrc.js

@@ -16,20 +16,39 @@ module.exports = {
     'react-hooks/rules-of-hooks': 'error',
     'react-hooks/exhaustive-deps': 'warn',
     'jest/no-test-callback': 'off',
+    'eslint-comments/disable-enable-pair': ['error', { allowWholeFile: true }],
     '@typescript-eslint/no-unused-vars': [
       'error',
       { argsIgnorePattern: '^_', ignoreRestSiblings: true },
     ],
-    '@typescript-eslint/camelcase': [
+    '@typescript-eslint/naming-convention': [
       'error',
       {
-        allow: [
-          'instant_search',
-          'instant_search_movies',
-          'free_shipping',
-          'facets_stats',
-          '^EXPERIMENTAL_',
-        ],
+        "selector": "variable",
+        "modifiers": ["destructured"],
+        "format": null
+      },
+      {
+        selector: 'variable',
+        format: ['camelCase', 'PascalCase', 'UPPER_CASE'],
+        leadingUnderscore: 'allow',
+        filter: {
+          regex: '^EXPERIMENTAL_|__DEV__',
+          match: false,
+        },
+      },
+      {
+        selector: 'typeParameter',
+        format: ['PascalCase'],
+        prefix: ['T', 'K'],
+      },
+      {
+        selector: 'interface',
+        format: ['PascalCase'],
+        custom: {
+          regex: '^I[A-Z]',
+          match: false,
+        },
       },
     ],
   },
@@ -40,6 +59,12 @@ module.exports = {
         'valid-jsdoc': 'off',
       },
     },
+    {
+      files: ['*.js'],
+      rules: {
+        '@typescript-eslint/explicit-member-accessibility': 'off',
+      },
+    },
   ],
   settings: {
     react: {

examples/e-commerce/.eslintrc.js

@@ -3,7 +3,7 @@ module.exports = {
   rules: {
     'valid-jsdoc': 'off',
     // The "no-unresolved" rule is needed for the CI
-    // because it runs ESLint without installating the
+    // because it runs ESLint without installing the
     // examples' dependencies first.
     'import/no-unresolved': 'off',
     'import/extensions': 'off',