Skip to content

Commit 2271b43

Browse files
authoredFeb 18, 2021
feat(ts): convert menu (#4652)
* feat(ts): convert menu - connectMenu - menu - menuSelect * test(menu): use real results * chore(deps): update helper * chore(hits): correct type for addQueryId * fix(ts): update helper again * chore(bundlesize): bump (answers)
1 parent ea56662 commit 2271b43

20 files changed

+865
-655
lines changed
 

‎package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
],
5454
"dependencies": {
5555
"@types/googlemaps": "^3.39.6",
56-
"algoliasearch-helper": "^3.3.4",
56+
"algoliasearch-helper": "^3.4.4",
5757
"classnames": "^2.2.5",
5858
"events": "^1.1.0",
5959
"hogan.js": "^3.0.2",
@@ -143,7 +143,7 @@
143143
"bundlesize": [
144144
{
145145
"path": "./dist/instantsearch.production.min.js",
146-
"maxSize": "66.15 kB"
146+
"maxSize": "66.50 kB"
147147
},
148148
{
149149
"path": "./dist/instantsearch.development.js",

‎src/components/MenuSelect/MenuSelect.tsx

+7-12
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ import { h } from 'preact';
44
import cx from 'classnames';
55
import { find } from '../../lib/utils';
66
import Template from '../Template/Template';
7-
8-
type MenuSelectTemplates = {
9-
defaultOption: string;
10-
item: string;
11-
};
7+
import {
8+
MenuSelectCSSClasses,
9+
MenuSelectTemplates,
10+
} from '../../widgets/menu-select/menu-select';
11+
import { MenuRendererOptions } from '../../connectors/menu/connectMenu';
1212

1313
type MenuItem = {
1414
/**
@@ -30,14 +30,9 @@ type MenuItem = {
3030
};
3131

3232
type Props = {
33-
cssClasses: {
34-
root: string;
35-
noRefinementRoot: string;
36-
select: string;
37-
option: string;
38-
};
33+
cssClasses: MenuSelectCSSClasses;
3934
items: MenuItem[];
40-
refine: (value: MenuItem['value']) => void;
35+
refine: MenuRendererOptions['refine'];
4136
templateProps: {
4237
templates: MenuSelectTemplates;
4338
};

0 commit comments

Comments
 (0)
Please sign in to comment.