Skip to content

Commit 07b7e08

Browse files
authoredJul 9, 2021
fix(deps): force a lower version of qs (#4805)
While this means it will be deduplicated less if people do use the later version of qs, it means a significant bundle size impact if we would have upgraded to 6.10+ (https://bundlephobia.com/package/qs@6.10.1 / ljharb/qs#404)
1 parent fc215a5 commit 07b7e08

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed
 

‎package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,13 @@
5454
"dependencies": {
5555
"@types/google.maps": "^3.45.3",
5656
"@types/hogan.js": "^3.0.0",
57+
"@types/qs": "^6.5.3",
5758
"algoliasearch-helper": "^3.5.4",
5859
"classnames": "^2.2.5",
5960
"events": "^1.1.0",
6061
"hogan.js": "^3.0.2",
6162
"preact": "^10.0.0",
62-
"qs": "^6.5.1"
63+
"qs": "^6.5.1 < 6.10"
6364
},
6465
"devDependencies": {
6566
"@algolia/client-search": "4.10.3",
@@ -81,7 +82,6 @@
8182
"@types/enzyme": "^3.1.15",
8283
"@types/jest": "^26.0.22",
8384
"@types/jest-diff": "^24.3.0",
84-
"@types/qs": "^6.5.3",
8585
"@types/storybook__addon-actions": "^3.4.2",
8686
"@typescript-eslint/eslint-plugin": "4.15.1",
8787
"@typescript-eslint/parser": "4.15.1",

‎yarn.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -11123,10 +11123,10 @@ qs@6.7.0:
1112311123
resolved "https://registry.yarnpkg.com/qs/-/qs-6.7.0.tgz#41dc1a015e3d581f1621776be31afb2876a9b1bc"
1112411124
integrity sha512-VCdBRNFTX1fyE7Nb6FYoURo/SPe62QCaAyzJvUjwRaIsc+NePBEniHlvxFmmX56+HZphIGtV0XeCirBtpDrTyQ==
1112511125

11126-
qs@^6.5.1, qs@^6.6.0:
11127-
version "6.8.0"
11128-
resolved "https://registry.yarnpkg.com/qs/-/qs-6.8.0.tgz#87b763f0d37ca54200334cd57bb2ef8f68a1d081"
11129-
integrity sha512-tPSkj8y92PfZVbinY1n84i1Qdx75lZjMQYx9WZhnkofyxzw2r7Ho39G3/aEvSUdebxpnnM4LZJCtvE/Aq3+s9w==
11126+
qs@^6.6.0, "qs@^6.5.1 < 6.10":
11127+
version "6.9.6"
11128+
resolved "https://registry.yarnpkg.com/qs/-/qs-6.9.6.tgz#26ed3c8243a431b2924aca84cc90471f35d5a0ee"
11129+
integrity sha512-TIRk4aqYLNoJUbd+g2lEdz5kLWIuTMRagAXxl78Q0RiVjAOugHmeKNGdd3cwo/ktpf9aL9epCfFqWDEKysUlLQ==
1113011130

1113111131
qs@~6.5.2:
1113211132
version "6.5.2"

0 commit comments

Comments
 (0)
Please sign in to comment.