-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(noResults): allow providing URL to report missing results #1289
Conversation
✔️ Deploy Preview for docsearch ready! 🔨 Explore the source changes: ac4b495 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsearch/deploys/61f960ee81996600072071a1 😎 Browse the preview: https://deploy-preview-1289--docsearch.netlify.app |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ac4b495:
|
@@ -50,6 +50,7 @@ export function DocSearchModal({ | |||
disableUserPersonalization = false, | |||
initialQuery: initialQueryFromProp = '', | |||
translations = {}, | |||
reportMissingResultsUrl, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's optional but there is are no default?
edit: the component is optional okay 🆗
bbfd921
to
0934664
Compare
4f1f3d2
to
ced2317
Compare
Summary
This PR provides an option for the user to define a link to report the missing results, nothing is rendered by default.
With the deprecation of our legacy infra (follow up of algolia/docsearch-configs#5069), the current value of this link (https://github.com/algolia/docsearch-configs) does not make sense anymore.
Other solutions
noResults
screen, which is also doable by importing the DocSearch components.