feat(noResults): allow providing URL to report missing results #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for docsearch ready! 🔨 Explore the source changes: ac4b495 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsearch/deploys/61f960ee81996600072071a1 😎 Browse the preview: https://deploy-preview-1289--docsearch.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ac4b495:
|
bodinsamuel
approved these changes
Jan 31, 2022
| @@ -50,6 +50,7 @@ export function DocSearchModal({ | |||
| disableUserPersonalization = false, | |||
| initialQuery: initialQueryFromProp = '', | |||
| translations = {}, | |||
| reportMissingResultsUrl, | |||
There was a problem hiding this comment.
it's optional but there is are no default?
edit: the component is optional okay 🆗
shortcuts
force-pushed
the
feat/noResults-missingResultsURL
branch
from
bbfd921
to
0934664
Compare
shortcuts
force-pushed
the
feat/noResults-missingResultsURL
branch
from
4f1f3d2
to
ced2317
Compare
francoischalifour
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR provides an option for the user to define a link to report the missing results, nothing is rendered by default.
With the deprecation of our legacy infra (follow up of algolia/docsearch-configs#5069), the current value of this link (https://github.com/algolia/docsearch-configs) does not make sense anymore.
Other solutions
noResultsscreen, which is also doable by importing the DocSearch components.