Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DocSearchProps): type searchParameters #1200

Merged
merged 1 commit into from Dec 3, 2021
Merged

fix(DocSearchProps): type searchParameters #1200

merged 1 commit into from Dec 3, 2021

Conversation

shortcuts
Copy link
Member

Summary

searchParameters were not typed

@shortcuts shortcuts self-assigned this Dec 3, 2021
@netlify
Copy link

netlify bot commented Dec 3, 2021 •
edited

✔️ Deploy Preview for docsearch canceled.

🔨 Explore the source changes: 032cb80

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsearch/deploys/61a9fbba561d390008d5c29c

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 3, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 032cb80:

Sandbox Source
Vanilla Configuration

bodinsamuel
bodinsamuel approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll advice to always use strict mode on typescript with no-explicit-any eslint rule

@shortcuts
Copy link
Member Author

I'll advice to always use strict mode on typescript with no-explicit-any eslint rule

Indeed, I'll add it in a future PR to do a pass on the types, before the stable release

@shortcuts shortcuts merged commit 80677fd into next Dec 3, 2021
@shortcuts shortcuts deleted the fix/docsearchprops branch December 3, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodinsamuel bodinsamuel bodinsamuel approved these changes

@francoischalifour francoischalifour Awaiting requested review from francoischalifour

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shortcuts @bodinsamuel