Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v3): pass initialQuery #1051

Merged
merged 1 commit into from Sep 30, 2021
Merged

fix(v3): pass initialQuery #1051

merged 1 commit into from Sep 30, 2021

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Sep 30, 2021 •
edited

Summary

initialQuery wasn't passed from the props to the state, which made it unusable.

see sandbox

Result

Search input is initialized with initialQuery

see sandbox

Related issue: #1050

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e15dc80:

Sandbox Source
Vanilla Configuration
festive-sara-7o8nf PR

@algolia algolia deleted a comment from netlify bot Sep 30, 2021
bodinsamuel
bodinsamuel approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@bodinsamuel bodinsamuel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I see no unit test in this repo, we might want to make the stack a bit more reliable at some point.

@shortcuts
Copy link
Member Author

I see no unit test in this repo, we might want to make the stack a bit more reliable at some point.

Since we mostly rely on Autocomplete, it's tested on that side, but we indeed should at least validate props.

I'll add a task to the backlog

@shortcuts shortcuts merged commit 6e194c7 into next Sep 30, 2021
@shortcuts shortcuts deleted the fix/initial-query branch September 30, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodinsamuel bodinsamuel bodinsamuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shortcuts @bodinsamuel