Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): new documentation #1048

Merged
merged 19 commits into from Oct 7, 2021
Merged

feat(website): new documentation #1048

merged 19 commits into from Oct 7, 2021

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Sep 22, 2021

Summary

This PR documents the new DocSearch infrastructure, the DocSearch v3 component and finalizes the migration from the previous website repository to this one.

Preview

You can see the live deploy with an up-to-date search.

Changes

legacy documentation

All of the actual documentation (minus references of the previous infra) is still available.

current documentation

  • Parts of the previously written documentation (what is DocSearch, goals, requirements, tips, etc.)
  • DocSearch v3
    • JS and React packages usage and API reference
    • CSS package (files only for now)
  • Crawler
    • helpers.docsearch extractor method, API and a few examples
    • Config templates for website generators
    • Other Crawler parts are documented on the Algolia documentation
  • Migration page with differences from legacy to current

Apply page

Due to many applications sent without reading the checklist (commercial usage for example), I thought having a checkbox for each requirements would be better.

README

READMEs have been updated with the new documentation links and a similar format to what we've done in Autocomplete

TODO

  • Fix Tailwindcss and Docusaurus styling conflict (Tailwind overrides the default Docusaurus styles)
  • Re-proofreading
  • Change Netlify deploy target

How to test

  • yarn && yarn website:start

When to merge

We will wait for the migration to officially start before publishing the new documentation

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 22, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3a0ec24:

Sandbox Source
Vanilla Configuration

@shortcuts shortcuts marked this pull request as ready for review September 22, 2021 12:34
Copy link
Contributor

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a very quick first pass on the first files.
This is very good, love it 😍❤️

  • Can not click "give it a star" banner at top (neither click or close)
  • On a 13" the homescreen is bit too big, I barely see the numbers, I would reduce a bit the up/down margin.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
packages/website/docs/what-is-docsearch.md Outdated Show resolved Hide resolved
packages/website/docs/what-is-docsearch.md Show resolved Hide resolved
packages/website/docs/who-can-apply.md Outdated Show resolved Hide resolved
packages/website/docusaurus.config.js Show resolved Hide resolved
packages/website/src/pages/index.js Outdated Show resolved Hide resolved
packages/website/docusaurus.config.js Outdated Show resolved Hide resolved
url: https://github.com/shortcuts
---

To help you create the best search experience for your users, we provide config templates for multiple websites generators. If you'd like to add a new template to our list, or believe we should update an existing one, please [send us an email][1] or [open a pull request][2]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would emphasis that all of them are accesible in the Crawler UI
And also that they are Crawler config.

A screenshot can help

@shortcuts
Copy link
Member Author

Can not click "give it a star" banner at top (neither click or close)

Indeed, there's also the stat banner and apply form that have a white background in dark mode after a hard refresh, but all of them work in dev. I'll check!

@Shipow
Copy link
Contributor

Shipow commented Sep 23, 2021

I love it! Let's go team!

Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed until "how-does-it-work.mdx" — great so far!

Would be nice to re-structure the sidebar sections as a follow-up PR, I have a hard time with the order and flow.

packages/website/docs/DocSearch-v3.mdx Show resolved Hide resolved
packages/website/docs/DocSearch-v3.mdx Outdated Show resolved Hide resolved
packages/website/docs/DocSearch-v3.mdx Show resolved Hide resolved
packages/website/docs/DocSearch-v3.mdx Outdated Show resolved Hide resolved
packages/website/docs/DocSearch-v3.mdx Outdated Show resolved Hide resolved
packages/website/docs/DocSearch-v3.mdx Show resolved Hide resolved
packages/website/docs/DocSearch-v3.mdx Show resolved Hide resolved
packages/website/docs/helpers.docsearch.md Outdated Show resolved Hide resolved
shortcuts and others added 3 commits September 24, 2021 09:38
Co-authored-by: François Chalifour <francoischalifour@users.noreply.github.com>
Co-authored-by: Samuel Bodin <samuel.bodin@algolia.com>
Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Maybe we can capitalize the versions in the dropdown? It's the only text that's not.

image

packages/website/docs/how-does-it-work.mdx Show resolved Hide resolved
packages/website/docs/required-configuration.mdx Outdated Show resolved Hide resolved
packages/website/docs/tips.md Outdated Show resolved Hide resolved
packages/website/package.json Outdated Show resolved Hide resolved
@shortcuts
Copy link
Member Author

Maybe we can capitalize the versions in the dropdown? It's the only text that's not.

I wanted to but didn't found a way to do it for the dropdown only, which means capitalizing it for the whole website and doesn't seem right in some places

@bodinsamuel
Copy link
Contributor

I wanted to but didn't found a way to do it for the dropdown only,

select > option { text-transform: capitalize } 😬

Copy link
Contributor

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive 🏋🏻

I have made a few suggestions, I'm not technical writer so feel free to discard it's just my own feeling.

packages/website/docs/faq.md Outdated Show resolved Hide resolved

:::note

This documentation will only contain informations regarding the **helpers.docsearch** method, see **[Algolia Crawler Documentation][7]** for more informations on the **[Algolia Crawler][8]**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be good to document it in our main Doc too, as we are now exposing it to everyone

packages/website/docs/how-does-it-work.mdx Outdated Show resolved Hide resolved
packages/website/docs/how-does-it-work.mdx Outdated Show resolved Hide resolved
packages/website/docs/migrating-from-legacy.md Outdated Show resolved Hide resolved
DocSearch can work with almost any website, but we've found that some site
structures yield more relevant results or faster indexing time. In this page
we'll share some tips on how you can make the most out of DocSearch.
DocSearch can work with almost any website, but we've found that some site structures yield more relevant results or faster indexing time. In this page we'll share some tips on how you can make the most out of DocSearch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page seems really similar to the end of packages/website/docs/required-configuration.mdx maybe you could gather the content

@sarahdayan
Copy link
Member

sarahdayan commented Sep 27, 2021

Great work @shortcuts! Here's a first pass of comments based on the visual aspect of the site. I'll do a second review of the code later on if you need to, although you probably already received a fair share of comments so let me know if this is needed or not.

I didn't check the previous reviews so feel free to disregard points if they have been discussed already.

Dark mode

The dark mode doesn't look as nice as the default light mode. The site looks "inverted", the contrast is either too low (text vs. background) or too strong (dark zones vs. light zones), and there are some readability issues.

The text is hard to read, and some logos don't play well with the dark background. Maybe silhouette logos would work better?

Capture d’écran 2021-09-27 à 13 13 28

The header doesn't distinguish for the hero background, which makes the hero pattern look "cut".

Capture d’écran 2021-09-27 à 13 15 26

My eye is drawn to that top banner.

Capture d’écran 2021-09-27 à 13 16 26

Weird issue where toggling between dark and light mode doesn't seem deterministic.

Enregistrement.de.l.ecran.2021-09-27.a.13.18.50.mov

Illustrations and icons

Some of the SVG illustrations use text with some ugly default serif font. I suspect this is because the text layer is still a text object. You could expand is as a vector shape to fix it.

Capture d’écran 2021-09-27 à 13 22 33

Capture d’écran 2021-09-27 à 13 22 40

I like the concept of this illustration, but I find it hard to read because of the angle and the fact that the search modal is just a blank rectangle.

Maybe using a vertical illustration, a bit tilted to the right, and filling the search modal would work better. Also, it doesn't need to be hi-fi, you could use a simplified style for it, similar to skeleton placeholders.

Capture d’écran 2021-09-27 à 13 24 45

This keyboard illustration is blurry, even on my Retina screen. Also, the top of the image is cropped.

It's worth checking with the design team if we have an account on Adobe Stock or similar, to grab a crisper image (like this one).

Capture d’écran 2021-09-27 à 13 27 48

Headings are misaligned because illustrations aren't of the same height.

Capture d’écran 2021-09-27 à 13 43 36

In one-line paragraphs, the icon doesn't align well.

Capture d’écran 2021-09-27 à 13 45 56

In the Algolia documentation there's a rule against exclamation marks (Google Developer style guide rule). This isn't documentation content, but exclamation marks in copywriting are a bit tacky. I'd recommend against them.

Capture d’écran 2021-09-27 à 13 46 47

Capture d’écran 2021-09-27 à 13 50 19

Documentation

This shouldn't be a docs page, but a standalone one.

Capture d’écran 2021-09-27 à 13 54 15

This is an odd, not very searchable heading.

Capture d’écran 2021-09-27 à 13 55 21

This admonition is too tone-on-tone, we can barely see it.

Capture d’écran 2021-09-27 à 13 55 55

These collapse widgets don't look as good as the rest, and the open/close transition is a bit slow.

Capture d’écran 2021-09-27 à 13 57 05

shortcuts and others added 2 commits September 27, 2021 16:28
Co-authored-by: Samuel Bodin <samuel.bodin@algolia.com>
Co-authored-by: François Chalifour <francoischalifour@users.noreply.github.com>
Copy link

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go, some free grammar and typo fixes. 😉

packages/website/docs/DocSearch-v3.mdx Outdated Show resolved Hide resolved
packages/website/docs/how-does-it-work.mdx Outdated Show resolved Hide resolved
packages/website/docs/how-does-it-work.mdx Outdated Show resolved Hide resolved
packages/website/docs/how-does-it-work.mdx Outdated Show resolved Hide resolved
packages/website/docs/migrating-from-legacy.md Outdated Show resolved Hide resolved
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Oct 7, 2021

✔️ Deploy Preview for docsearch ready!

🔨 Explore the source changes: 3a0ec24

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsearch/deploys/615eca4dcb64820007d70927

😎 Browse the preview: https://deploy-preview-1048--docsearch.netlify.app

@algolia algolia deleted a comment from netlify bot Oct 7, 2021
@shortcuts shortcuts merged commit 9a89cde into next Oct 7, 2021
@shortcuts shortcuts deleted the website branch October 7, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants