fix(button): prevent container keys ui flash #1033
Merged
+12
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1021
Summary
This PR prevent the UI flash for server-side rendered websites. Since the
key
value isnull
, thekeys
container isn't rendered and therefore causes a UI flash.Result
The condition is now a level below (on the
key
s), and we've added a fixedwidth
to the container.Preview
Screen.Recording.2021-07-23.at.15.47.59.mov
Related