Skip to content

Commit

Permalink
feat(v3): require appId (#1299)
Browse files Browse the repository at this point in the history
BREAKING CHANGE
shortcuts authored Feb 21, 2022

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
1 parent b91983d commit 80630cb
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/docsearch-react/src/DocSearch.tsx
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@ export type DocSearchTranslations = Partial<{
}>;

export interface DocSearchProps {
appId?: string;
appId: string;
apiKey: string;
indexName: string;
placeholder?: string;
2 changes: 1 addition & 1 deletion packages/docsearch-react/src/DocSearchModal.tsx
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@ export type DocSearchModalProps = DocSearchProps & {
};

export function DocSearchModal({
appId = 'BH4D9OD16A',
appId,
apiKey,
indexName,
placeholder = 'Search docs',
4 changes: 3 additions & 1 deletion packages/docsearch-react/src/__tests__/api.test.tsx
Original file line number Diff line number Diff line change
@@ -13,7 +13,9 @@ import { DocSearch as DocSearchComponent } from '../DocSearch';
import type { DocSearchProps } from '../DocSearch';

function DocSearch(props: Partial<DocSearchProps>) {
return <DocSearchComponent apiKey="foo" indexName="bar" {...props} />;
return (
<DocSearchComponent appId="woo" apiKey="foo" indexName="bar" {...props} />
);
}

// mock empty response

0 comments on commit 80630cb

Please sign in to comment.