Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ZJONSSON/node-unzipper
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ab64d6a38b5f091384334dd7aff283f0a5073878
Choose a base ref
...
head repository: ZJONSSON/node-unzipper
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 30957973ad24777f2d8504f1ff070f98f05fdd12
Choose a head ref
  • 17 commits
  • 27 files changed
  • 8 contributors

Commits on Sep 3, 2023

  1. Update README.md

    fix grammatical error
    syedhannan authored Sep 3, 2023
    Copy the full SHA
    c7937bd View commit details
  2. Update README.md

    syedhannan authored Sep 3, 2023
    Copy the full SHA
    2dbd02b View commit details

Commits on Apr 14, 2024

  1. Merge pull request #284 from syedhannan/master

    Update README.md
    ZJONSSON authored Apr 14, 2024
    Copy the full SHA
    0c0c1f0 View commit details
  2. add github actions

    ZJONSSON committed Apr 14, 2024
    Copy the full SHA
    4e46226 View commit details
  3. Merge pull request #298 from ZJONSSON/github-actions

    Add github actions
    ZJONSSON authored Apr 14, 2024
    Copy the full SHA
    9448b79 View commit details
  4. Fix tests

    ZJONSSON committed Apr 14, 2024
    Copy the full SHA
    40dabb1 View commit details
  5. Merge pull request #299 from ZJONSSON/github-actions

    Fix tests
    ZJONSSON authored Apr 14, 2024
    Copy the full SHA
    e02fce8 View commit details
  6. Fix coverage

    ZJONSSON committed Apr 14, 2024
    Copy the full SHA
    8f659bc View commit details
  7. Merge pull request #300 from ZJONSSON/github-actions

    Fix coverage
    ZJONSSON authored Apr 14, 2024
    Copy the full SHA
    41a5199 View commit details
  8. Fix coverage badge

    ZJONSSON authored Apr 14, 2024
    Copy the full SHA
    fca11e5 View commit details
  9. chore: fix typo in README (#281)

    Co-authored-by: Ziggy Jonsson <ziggy.jonsson.nyc@gmail.com>
    bobbyg603 and ZJONSSON authored Apr 14, 2024
    Copy the full SHA
    b94faa8 View commit details
  10. Removing binary dependency (#283)

    * Removing binary dependency
    
    * Adding unit test for parseBuffer
    
    ---------
    
    Co-authored-by: amcgoogan <amcgoogan@gmail.com>
    pdugas and amcgoogan authored Apr 14, 2024
    Copy the full SHA
    18e799d View commit details
  11. Remove-polyfills (#301)

    ZJONSSON authored Apr 14, 2024
    Copy the full SHA
    7b3c0b4 View commit details
  12. Break the huge promise chain (#257)

    * Break the huge promise chain, use a loop
    
    By using a loop over all records instead of building a huge promise chain, we avoid the issue documented in #254 where the promise chain ends up taking up all the memory of an application.
    
    In short, this commit allows the garbage collector to collect the small promises as they resolve, rather than building one huge chain that keeps references to the future "then"s.
    
    The downside of this approach currently is that it relies on async/await syntax in order to allow awaits inside loops, which is what can fix the issue here. Im sure we can find a solution without this if it is significant, and we put our minds to it!
    
    * Async-free solution with no eternal promise chain
    
    In this approach, I have removed the dependency on async/await syntax, but also avoided eternal promise chains by using a top-level promise that allows sub-promises to compute to fulfillment before moving on.
    hypesystem authored Apr 14, 2024
    Copy the full SHA
    c743527 View commit details
  13. Fix: Unix OS's should properly ignore the windows zip slipped files (#…

    …179)
    
    * Fix: Unix OS's should properly ignore the windows zip slipped files as well.
    
    * Tests: resurrected the original zip-slip test as is as requested
    Glen-Nicol-Garmin authored Apr 14, 2024
    Copy the full SHA
    7c4604e View commit details
  14. fix: use pipeline to propagate errors across all piped streams (#288)

    Co-authored-by: Ziggy Jonsson <ziggy.jonsson.nyc@gmail.com>
    oaleynik and ZJONSSON authored Apr 14, 2024
    Copy the full SHA
    d7f01ee View commit details
  15. bump minor (#302)

    ZJONSSON authored Apr 14, 2024
    Copy the full SHA
    3095797 View commit details
Loading