Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
8
contributors
Commits on Dec 25, 2015
Commits on Jan 26, 2016
Commits on Feb 22, 2016
-
Fix Cannot read property 'nodeValue' of undefined exception that is t…
…hrown when a <key></key> construct appears in plist
Commits on Feb 23, 2016
-
Merge pull request #70 from chriskinsman/master
Fix Cannot read property 'nodeValue' of undefined exception that is t…
Commits on Mar 13, 2016
-
-
Merge pull request #69 from agoldis/master
Fixed empty keys issue #66, added tests
Commits on May 12, 2016
-
Merge pull request #73 from mitchhentges/reduce-package-size
Update dependencies to reduce package size
Commits on Jul 8, 2016
-
-
Merge pull request #76 from amilajack/patch-1
Added travis ci support for node 6
-
Merge pull request #68 from mrzmyr/add-verbose-examples
add verbose examples
Commits on Aug 16, 2016
-
Now there's only `build()` and `parse()`! They've been deprecated for a long time now, and this should resolve #77 as well.
-
-
-
-
-
Commits on Feb 12, 2017
-
Harden test-cases and implementation to align with other implementations
This commit refactors and adds more tests to the `parse()` implementation to align with similar libraries's behaviour, e.g.: - https://github.com/Microsoft/node-fast-plist - https://docs.python.org/3/library/plistlib.html With the new tests a few of the tests were failing: ``` 31 passing (177ms) 10 failing 1) parse() real should throw an Error when parsing an empty real: AssertionError: Missing expected exception.. 2) parse() string should parse a self closing string: AssertionError: null === '' 3) parse() string should parse an empty string: AssertionError: null === '' 4) parse() string should parse a string with comments: AssertionError: 'a comment string' === 'a string' 5) parse() array should parse empty elements inside an array: AssertionError: [ false ] deepEqual [ '', false ] 6) parse() dict should throw if key is missing: AssertionError: Missing expected exception.. 7) parse() dict should throw if two keys follow each other: AssertionError: Missing expected exception.. 8) parse() dict should throw if value is missing: AssertionError: Missing expected exception.. 9) parse() dict should parse an empty key: AssertionError: {} deepEqual { '': '1' } 10) parse() dict should parse an empty value: AssertionError: { a: null } deepEqual { a: '' } ``` This commit also refactors the `lib/parse.js` to pass these tests. When executing the new implementation of `lib/parse.js` agains the old tests the following tests were failing: ``` 25 passing (143ms) 3 failing 1) plist parse() should parse an empty <key/> in a dictionary: AssertionError: false == true 2) plist parse() should parse an empty <key></key> in a dictionary: AssertionError: false == true 3) plist parse() should parse an empty <key></key> and <string></string> in dictionary with more data: AssertionError: { '': '', UIRequiredDeviceCapabilities: [ 'armv7' ] } deepEqual { UIRequiredDeviceCapabilities: [ 'armv7' ] } ``` As the output above shows, most of the issue are with the handling of empty strings and empty dictionary keys. Added with the new implementation are custom Errors for unexpected input, better handling of comments inside tags and a more aligned handling of empty keys/strings.
Commits on Feb 19, 2017
-
-
Merge pull request #84 from ZauberNerd/harden-parser
Harden test-cases and align with other implementations
There are no files selected for viewing