avoid using Buffer constructor nodejs/node#19079

mreinstein · mreinstein · commit a7d03aad222a · 2018-03-21T09:29:18.000-07:00
diff --git a/dist/plist-parse.js b/dist/plist-parse.js
@@ -192,14 +192,14 @@ function parsePlistXML (node) {
   } else if (node.nodeName === 'data') {
     res = '';
     if (isEmptyNode(node)) {
-      return new Buffer(res, 'base64');
+      return Buffer.from(res, 'base64');
     }
     for (i=0; i < node.childNodes.length; i++) {
       if (node.childNodes[i].nodeType === TEXT_NODE) {
         res += node.childNodes[i].nodeValue.replace(/\s+/g, '');
       }
     }
-    return new Buffer(res, 'base64');
+    return Buffer.from(res, 'base64');
 
   } else if (node.nodeName === 'date') {
     invariant(
diff --git a/dist/plist.js b/dist/plist.js
@@ -348,14 +348,14 @@ function parsePlistXML (node) {
   } else if (node.nodeName === 'data') {
     res = '';
     if (isEmptyNode(node)) {
-      return new Buffer(res, 'base64');
+      return Buffer.from(res, 'base64');
     }
     for (i=0; i < node.childNodes.length; i++) {
       if (node.childNodes[i].nodeType === TEXT_NODE) {
         res += node.childNodes[i].nodeValue.replace(/\s+/g, '');
       }
     }
-    return new Buffer(res, 'base64');
+    return Buffer.from(res, 'base64');
 
   } else if (node.nodeName === 'date') {
     invariant(
diff --git a/lib/parse.js b/lib/parse.js
@@ -190,14 +190,14 @@ function parsePlistXML (node) {
   } else if (node.nodeName === 'data') {
     res = '';
     if (isEmptyNode(node)) {
-      return new Buffer(res, 'base64');
+      return Buffer.from(res, 'base64');
     }
     for (i=0; i < node.childNodes.length; i++) {
       if (node.childNodes[i].nodeType === TEXT_NODE) {
         res += node.childNodes[i].nodeValue.replace(/\s+/g, '');
       }
     }
-    return new Buffer(res, 'base64');
+    return Buffer.from(res, 'base64');
 
   } else if (node.nodeName === 'date') {
     invariant(
diff --git a/package-lock.json b/package-lock.json

Original file line number	Diff line number	Diff line change
`@@ -192,14 +192,14 @@ function parsePlistXML (node) {`
`192`	`192`	`} else if (node.nodeName === 'data') {`
`193`	`193`	`res = '';`
`194`	`194`	`if (isEmptyNode(node)) {`
`195`		`- return new Buffer(res, 'base64');`
	`195`	`+ return Buffer.from(res, 'base64');`
`196`	`196`	`}`
`197`	`197`	`for (i=0; i < node.childNodes.length; i++) {`
`198`	`198`	`if (node.childNodes[i].nodeType === TEXT_NODE) {`
`199`	`199`	`res += node.childNodes[i].nodeValue.replace(/\s+/g, '');`
`200`	`200`	`}`
`201`	`201`	`}`
`202`		`- return new Buffer(res, 'base64');`
	`202`	`+ return Buffer.from(res, 'base64');`
`203`	`203`
`204`	`204`	`} else if (node.nodeName === 'date') {`
`205`	`205`	`invariant(`
Original file line number	Diff line number	Diff line change
`@@ -348,14 +348,14 @@ function parsePlistXML (node) {`
`348`	`348`	`} else if (node.nodeName === 'data') {`
`349`	`349`	`res = '';`
`350`	`350`	`if (isEmptyNode(node)) {`
`351`		`- return new Buffer(res, 'base64');`
	`351`	`+ return Buffer.from(res, 'base64');`
`352`	`352`	`}`
`353`	`353`	`for (i=0; i < node.childNodes.length; i++) {`
`354`	`354`	`if (node.childNodes[i].nodeType === TEXT_NODE) {`
`355`	`355`	`res += node.childNodes[i].nodeValue.replace(/\s+/g, '');`
`356`	`356`	`}`
`357`	`357`	`}`
`358`		`- return new Buffer(res, 'base64');`
	`358`	`+ return Buffer.from(res, 'base64');`
`359`	`359`
`360`	`360`	`} else if (node.nodeName === 'date') {`
`361`	`361`	`invariant(`
Original file line number	Diff line number	Diff line change
`@@ -190,14 +190,14 @@ function parsePlistXML (node) {`
`190`	`190`	`} else if (node.nodeName === 'data') {`
`191`	`191`	`res = '';`
`192`	`192`	`if (isEmptyNode(node)) {`
`193`		`- return new Buffer(res, 'base64');`
	`193`	`+ return Buffer.from(res, 'base64');`
`194`	`194`	`}`
`195`	`195`	`for (i=0; i < node.childNodes.length; i++) {`
`196`	`196`	`if (node.childNodes[i].nodeType === TEXT_NODE) {`
`197`	`197`	`res += node.childNodes[i].nodeValue.replace(/\s+/g, '');`
`198`	`198`	`}`
`199`	`199`	`}`
`200`		`- return new Buffer(res, 'base64');`
	`200`	`+ return Buffer.from(res, 'base64');`
`201`	`201`
`202`	`202`	`} else if (node.nodeName === 'date') {`
`203`	`203`	`invariant(`