Skip to content

Commit 5639745

Browse files
committedAug 5, 2021
Merge branch 'fix-build'
2 parents e5b3f0d + e08003e commit 5639745

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed
 

‎.gitignore

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
*~
2+
.c9revisions
3+
.DS_Store
24
node_modules
3-
sauce_connect.log
4-
.c9revisions
5+
sauce_connect.log

‎documentation/contributing.md

+8-6
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,14 @@ If you have tested bug fixes or new features, you can open a
6363

6464
## Releasing a new version
6565

66-
1. Run `npm test`
66+
1. In `package.json` temporarily change `"./lib/index"` to `"."`
67+
2. Run `npm test`
6768
* Locally open http://localhost:8080/test/
6869
* Or use the SauceLabs configuration above
69-
2. Update `JSZip.version` in `index.js` and in `package.json`
70-
3. Run `grunt` to generate the new dist files
70+
3. Update `JSZip.version` in `index.js` and in `package.json`
71+
4. Run `grunt` to generate the new dist files
7172
* undo the package.json change, it was just needed to replace the `__VERSION__` in the header
72-
4. Update CHANGES.md
73-
5. Run `npm version ...` where `...` is `major`, `minor`, or `patch`
74-
6. Run npm publish
73+
5. Undo step 1.
74+
6. Update CHANGES.md
75+
7. Run `npm version ...` where `...` is `major`, `minor`, or `patch`
76+
8. Run npm publish

‎test/asserts/load.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@ QUnit.module("load", function () {
2222
assert.ok(typeof file === "string");
2323
JSZip.loadAsync(file)
2424
.then(function (zip) {
25-
// Passes in Node, fails in browsers:
26-
// assert.equal(Object.getPrototypeOf(zip.files), zip.files.__proto__); // jshint ignore:line
25+
assert.notEqual(Object.getPrototypeOf(zip.files), zip.files.__proto__); // jshint ignore:line
2726
return zip.file("__proto__").async("string"); })
2827
.then(function(result) {
2928
assert.equal(result, "hello\n", "the zip was correctly read.");

0 commit comments

Comments
 (0)
Please sign in to comment.