Merge pull request #1779 from mkholjuraev/pdf-export

fix(usePDFExport): add missing dispatch call

Author: mkholjuraev

packages/utils/src/useExportPDF/useExportPDF.test.js

@@ -8,11 +8,12 @@ jest.mock('@redhat-cloud-services/frontend-components-notifications/redux', () =
 
 window.URL.createObjectURL = jest.fn();
 global.fetch = jest.fn();
+const dispatch = jest.fn();
 
 describe('useExportPDF', () => {
   it('Should download PDF', async () => {
     global.fetch.mockReturnValueOnce(Promise.resolve({ blob: jest.fn() }));
-    const exportPDF = useExportPDF('vulnerability');
+    const exportPDF = useExportPDF('vulnerability', dispatch);
     await exportPDF('executiveReport', 'vulnerability-test-export', { someRequestPayload: 'some value' });
     expect(fetch).toHaveBeenCalledWith(pdfGeneratorURL, {
       body: '{"service":"vulnerability","template":"executiveReport","params":{"someRequestPayload":"some value"}}',
@@ -32,7 +33,7 @@ describe('useExportPDF', () => {
   it('Should fail to download PDF with notification', async () => {
     global.fetch.mockReturnValueOnce(Promise.reject('error'));
 
-    const exportPDF = useExportPDF('vulnerability');
+    const exportPDF = useExportPDF('vulnerability', dispatch);
     await exportPDF('executiveReport', 'vulnerability-test-export', { someRequestPayload: 'some value' });
     expect(addNotification).toHaveBeenCalledWith({
       description: 'Reinitiate this export to try again.',

packages/utils/src/useExportPDF/useExportPDF.ts

@@ -30,26 +30,32 @@ const renderPDF = (pdfBlob: Blob, fileName = 'new-report') => {
 
 // Hook to provide a function that request pdf-generator service to generate report blob
 // and convert returned blob into pdf
-const usePDFExport = (service: string) => {
+const usePDFExport = (service: string, dispatch: any) => {
   const exportPDF = async (template: string, filename: string, exportSettings: Record<string, unknown>) => {
-    addNotification({
-      variant: 'info',
-      title: 'Preparing export',
-      description: 'Once complete, your download will start automatically.',
-    });
+    dispatch(
+      addNotification({
+        variant: 'info',
+        title: 'Preparing export',
+        description: 'Once complete, your download will start automatically.',
+      })
+    );
     try {
       const pdfBlob = await fetchPDF(service, template, exportSettings);
       renderPDF(pdfBlob, filename);
-      addNotification({
-        variant: 'success',
-        title: 'Downloading export',
-      });
+      dispatch(
+        addNotification({
+          variant: 'success',
+          title: 'Downloading export',
+        })
+      );
     } catch (e) {
-      addNotification({
-        variant: 'danger',
-        title: 'Couldn’t download export',
-        description: 'Reinitiate this export to try again.',
-      });
+      dispatch(
+        addNotification({
+          variant: 'danger',
+          title: 'Couldn’t download export',
+          description: 'Reinitiate this export to try again.',
+        })
+      );
     }
   };