Merge pull request #1757 from Fewwy/reportdetails-kek

Hyperkid123 · web-flow · commit 914778b503f5 · 2023-08-01T12:54:33.000+02:00
fix(advisor-3041): fixing external link crash
diff --git a/packages/advisor-components/src/ReportDetails/ReportDetails.tsx b/packages/advisor-components/src/ReportDetails/ReportDetails.tsx
@@ -100,7 +100,7 @@ const ReportDetails: React.FC<ReportDetailsProps> = ({
                       <React.Fragment>
                         <ExternalLink
                           href={`${linkEditor(kbaDetail?.view_uri)}`}
-                          content={kbaDetail.publishedTitle ? kbaDetail.publishedTitle : `Knowledgebase article`}
+                          content={kbaDetail?.publishedTitle ? kbaDetail?.publishedTitle : `Knowledgebase article`}
                         />
                         .
                       </React.Fragment>
diff --git a/packages/advisor-components/src/common.tsx b/packages/advisor-components/src/common.tsx
@@ -25,7 +25,7 @@ export const topicLinks = (rule: RuleContentRhel, topics: TopicRhel[], Link: any
       )
     : [];
 
-export const ExternalLink = ({ href, content }: { href: string; content: string }) => (
+export const ExternalLink = ({ href = '', content = '' }: { href: string; content: string }) => (
   <a rel="noopener noreferrer" target="_blank" href={href}>
     {content} <i className="fas fa-external-link-alt" />
   </a>

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ const ReportDetails: React.FC<ReportDetailsProps> = ({`
`100`	`100`	`<React.Fragment>`
`101`	`101`	`<ExternalLink`
`102`	`102`	href={`${linkEditor(kbaDetail?.view_uri)}`}
`103`		- content={kbaDetail.publishedTitle ? kbaDetail.publishedTitle : `Knowledgebase article`}
	`103`	+ content={kbaDetail?.publishedTitle ? kbaDetail?.publishedTitle : `Knowledgebase article`}
`104`	`104`	`/>`
`105`	`105`	`.`
`106`	`106`	`</React.Fragment>`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ export const topicLinks = (rule: RuleContentRhel, topics: TopicRhel[], Link: any`
`25`	`25`	`)`
`26`	`26`	`: [];`
`27`	`27`
`28`		`-export const ExternalLink = ({ href, content }: { href: string; content: string }) => (`
	`28`	`+export const ExternalLink = ({ href = '', content = '' }: { href: string; content: string }) => (`
`29`	`29`	`<a rel="noopener noreferrer" target="_blank" href={href}>`
`30`	`30`	`{content} <i className="fas fa-external-link-alt" />`
`31`	`31`	`</a>`