Skip to content

Commit 6a47dc6

Browse files
authoredAug 15, 2023
Merge branch 'master' into fix-checkbox-filter
2 parents 1eb9e76 + 9eda19e commit 6a47dc6

File tree

6 files changed

+15
-12
lines changed

6 files changed

+15
-12
lines changed
 

‎packages/components/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@redhat-cloud-services/frontend-components",
3-
"version": "3.11.2",
3+
"version": "3.11.3",
44
"description": "Common components for RedHat Cloud Services project.",
55
"main": "index.js",
66
"module": "esm/index.js",

‎packages/components/src/RBACProvider/RBACProvider.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ import {
1111
} from '@redhat-cloud-services/frontend-components-utilities/RBAC';
1212

1313
const hasAccessWithUserPermissions = (userPermissions: (Access | string)[], checkResourceDefinitions: boolean) => {
14-
return (requiredPermissions: (Access | string)[], checkAll?: boolean): boolean => {
14+
return (requiredPermissions: (Access | string)[], checkAll?: boolean, checkResourceDefinitionsOverride?: boolean): boolean => {
1515
return checkAll
16-
? hasAllPermissions(userPermissions, requiredPermissions, checkResourceDefinitions)
17-
: doesHavePermissions(userPermissions, requiredPermissions, checkResourceDefinitions);
16+
? hasAllPermissions(userPermissions, requiredPermissions, checkResourceDefinitionsOverride ?? checkResourceDefinitions)
17+
: doesHavePermissions(userPermissions, requiredPermissions, checkResourceDefinitionsOverride ?? checkResourceDefinitions);
1818
};
1919
};
2020

‎packages/demo/src/index.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
<meta charset="utf-8">
66
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
77
<meta name="theme-color" content="#000000">
8-
<link rel="stylesheet" type="text/css" href="https://unpkg.com/@patternfly/patternfly@latest/patternfly-base.css"/>
9-
<link rel="stylesheet" type="text/css" href="https://unpkg.com/@patternfly/patternfly@latest/patternfly-addons.css"/>
8+
<link rel="stylesheet" type="text/css" href="https://unpkg.com/@patternfly/patternfly@4.224.5/patternfly-base.css"/>
9+
<link rel="stylesheet" type="text/css" href="https://unpkg.com/@patternfly/patternfly@4.224.5/patternfly-addons.css"/>
1010
<!--
1111
manifest.json provides metadata used when your web app is added to the
1212
homescreen on Android. See https://developers.google.com/web/fundamentals/engage-and-retain/web-app-manifest/

‎packages/utils/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@redhat-cloud-services/frontend-components-utilities",
3-
"version": "3.7.4",
3+
"version": "3.7.6",
44
"description": "Util functions for RedHat Cloud Services project.",
55
"main": "index.js",
66
"module": "esm/index.js",

‎packages/utils/src/RBAC/RBAC.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,7 @@ function extractResourceDefinitionValues(rds: ResourceDefinition[]) {
3636
if (operation === ResourceDefinitionFilterOperationEnum.In) {
3737
return [
3838
...acc,
39-
...value
40-
.toString()
39+
...(Array.isArray(value) ? value.map((value) => (value === null ? 'null' : value)).toString() : value)
4140
.split(',')
4241
.map((value) => `${key}:${value}`),
4342
];
@@ -135,7 +134,7 @@ export interface UsePermissionsContextState {
135134
isLoading?: boolean;
136135
isOrgAdmin: boolean;
137136
permissions: (string | Access)[];
138-
hasAccess?: (requiredPermissions: (Access | string)[], checkAll?: boolean) => boolean;
137+
hasAccess?: (requiredPermissions: (Access | string)[], checkAll?: boolean, checkResourceDefinitionsOverride?: boolean) => boolean;
139138
}
140139

141140
export const initialPermissions: UsePermissionsContextState = {

‎packages/utils/src/RBACHook/RBACHook.ts

+6-2
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,16 @@ export function usePermissions(
3939
return permissions;
4040
}
4141

42-
export const usePermissionsWithContext = (requiredPermissions: (Access | string)[], checkAll?: boolean) => {
42+
export const usePermissionsWithContext = (
43+
requiredPermissions: (Access | string)[],
44+
checkAll?: boolean,
45+
checkResourceDefinitionsOverride?: boolean
46+
) => {
4347
const { hasAccess, ...permissionState } = useContext(RBACContext);
4448

4549
return {
4650
...permissionState,
47-
hasAccess: hasAccess?.(requiredPermissions, checkAll) || false,
51+
hasAccess: hasAccess?.(requiredPermissions, checkAll, checkResourceDefinitionsOverride) || false,
4852
};
4953
};
5054

0 commit comments

Comments
 (0)