Remove check for beacon in proposeUpgrade (#745)

Author: ericglau

packages/plugin-defender-hardhat/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+- Remove check for beacon in `proposeUpgrade`. ([#745](https://github.com/OpenZeppelin/openzeppelin-upgrades/pull/745))
+
 ## 1.8.1 (2022-09-27)
 
 - Silence warning about missing Defender configuration unless it is required. ([#663](https://github.com/OpenZeppelin/openzeppelin-upgrades/pull/663))

packages/plugin-defender-hardhat/src/propose-upgrade.ts

@@ -2,7 +2,6 @@ import { UpgradeOptions } from '@openzeppelin/hardhat-upgrades';
 import '@openzeppelin/hardhat-upgrades/dist/type-extensions';
 import {
   getImplementationAddress,
-  isBeacon,
   isBeaconProxy,
   isTransparentOrUUPSProxy,
   isTransparentProxy,
@@ -43,8 +42,6 @@ export function makeProposeUpgrade(hre: HardhatRuntimeEnvironment): ProposeUpgra
 
     if (await isBeaconProxy(hre.network.provider, proxyAddress)) {
       throw new Error(`Beacon proxy is not currently supported with defender.proposeUpgrade()`);
-    } else if (await isBeacon(hre.network.provider, proxyAddress)) {
-      throw new Error(`Beacon is not currently supported with defender.proposeUpgrade()`);
     } else if (
       !multisig &&
       (await isTransparentOrUUPSProxy(hre.network.provider, proxyAddress)) &&

packages/plugin-defender-hardhat/test/propose-upgrade-beacon.js

@@ -48,7 +48,7 @@ test('block proposing an upgrade on beacon', async t => {
   const title = 'My upgrade';
   const description = 'My contract upgrade';
   await t.throwsAsync(() => proposeUpgrade(greeterBeacon.address, GreeterV2, { title, description }), {
-    message: 'Beacon is not currently supported with defender.proposeUpgrade()',
+    message: /Contract at \S+ doesn't look like an ERC 1967 proxy with a logic contract address/,
   });
 });
 
@@ -81,6 +81,6 @@ test('block proposing an upgrade reusing prepared implementation on beacon', asy
 
   await upgrades.prepareUpgrade(greeterBeacon.address, GreeterV2);
   await t.throwsAsync(() => proposeUpgrade(greeterBeacon.address, GreeterV2), {
-    message: 'Beacon is not currently supported with defender.proposeUpgrade()',
+    message: /Contract at \S+ doesn't look like an ERC 1967 proxy with a logic contract address/,
   });
 });