Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: MailOnline/eslint-config-mailonline
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9ee27a3e037ffc3606ba8c9257d6e580eadd213a
Choose a base ref
...
head repository: MailOnline/eslint-config-mailonline
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 53e0f8c7efa3d2a3a38c0ffd354d5b8c3cf1a474
Choose a head ref
  • 9 commits
  • 19 files changed
  • 3 contributors

Commits on Sep 11, 2017

  1. chore: make webpack optional

    @claudiorodriguez
    claudiorodriguez committed Sep 11, 2017
    Copy the full SHA
    2d55514 View commit details

  2. chore: remove package-lock

    @claudiorodriguez
    claudiorodriguez committed Sep 11, 2017
    Copy the full SHA
    94a7e2b View commit details

  3. fix: fix travis targets

    @claudiorodriguez
    claudiorodriguez committed Sep 11, 2017
    Copy the full SHA
    c5eb8a7 View commit details

Commits on Oct 5, 2017

  1. fix: relax React rules

    @streamich
    Vadim Dalecky authored and streamich committed Oct 5, 2017
    Copy the full SHA
    135bda2 View commit details

Commits on Oct 23, 2017

  1. feat: forbid anonymous defaults 

    Everthing exported should be named. This change also discorages exports like:
```
export default {
  one,
  two,
  ...
}
```
Which prevent efficient treeshaking. As the compiler can't know what
can be needed on compile time.

BREAKING CHANGE: any anonymous export will fail from now on.
    @carpasse
    carpasse committed Oct 23, 2017
    Copy the full SHA
    0ab36cc View commit details

Commits on Nov 14, 2017

  1. feat: remove import/prefer-default-export and import/max-dependencies

    @streamich
    Vadim Dalecky authored and streamich committed Nov 14, 2017
    Copy the full SHA
    6d96ee2 View commit details

Commits on Nov 20, 2017

  1. fix: move react overrides to react config 

    There were some react overrides in the base config,
but they need to be in the react-specific config
    @claudiorodriguez
    claudiorodriguez committed Nov 20, 2017
    Copy the full SHA
    aafc230 View commit details

  2. fix: move canonical rules into package 

    Moves the rules in canonical inside the package
for ease of maintenance and to take control
of dependencies.

BREAKING CHANGE: removes ava rules
    @claudiorodriguez
    claudiorodriguez committed Nov 20, 2017
    Copy the full SHA
    d622962 View commit details

  3. fix: disable import/no-namespace

    @claudiorodriguez
    claudiorodriguez committed Nov 20, 2017
    Copy the full SHA
    53e0f8c View commit details
Showing with 971 additions and 3,409 deletions.
  1. +1 −0 .gitignore
  2. +4 −3 .travis.yml
  3. +0 −8 README.md
  4. +0 −1 ava.js
  5. +663 −0 configurations/base.json
  6. +61 −0 configurations/flowtype.json
  7. +14 −0 configurations/jest.json
  8. +68 −0 configurations/lodash.json
  9. +22 −0 configurations/mocha.json
  10. +107 −0 configurations/react.json
  11. +0 −17 eslintrc.json
  12. +1 −1 flowtype.js
  13. +1 −1 index.js
  14. +1 −1 jest.js
  15. +1 −1 lodash.js
  16. +1 −1 mocha.js
  17. +0 −3,367 package-lock.json
  18. +25 −7 package.json
  19. +1 −1 react.js
1 change: 1 addition & 0 deletions .gitignore
View file
Original file line number Diff line number Diff line change
@@ -4,3 +4,4 @@ node_modules
!.gitignore
!.npmignore
!.travis.yml
package-lock.json
7 changes: 4 additions & 3 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
@@ -3,11 +3,12 @@ language: node_js
notifications:
email: false
node_js:
- 7
- 6
- 5
- 8
script:
- npm run test
- npm run lint
after_success:
- npm run semantic-release
branches:
except:
- /^v\d+\.\d+\.\d+$/
8 changes: 0 additions & 8 deletions README.md
View file
Original file line number Diff line number Diff line change
@@ -76,14 +76,6 @@ either in a folder-specific eslint config, or additionally to the root config, e
}
```

### ava

```json
{
"extends": "mailonline/ava"
}
```

### webpack

```json
1 change: 0 additions & 1 deletion ava.js
View file

This file was deleted.

Loading