GridLayer: fix _updateLevels and _removeTilesAtZoom #7123
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of particular quality of `for ... in` loop, type of `z` is 'string'. Thus condition `z === zoom` never met in _updateLevels. Considering wrong arg type, _removeTilesAtZoom also never had any action. Cleaner solution would be to iterate `Object.keys()` instead, but it is available only since IE 9.
johnd0e
force-pushed
the
fix_removeTilesAtZoom
branch
from
3d2e90f to
233a718
Compare
johnd0e
changed the title
mourner
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of particular quality of
for ... inloop, type ofzis 'string'.Thus condition
z === zoomnever met in _updateLevels.Considering wrong arg type, _removeTilesAtZoom also never had any action.
Cleaner solution would be to iterate
Object.keys()instead, but it is available only since IE 9.Note: the fix here is pretty same as #6064.
Additionally I've checked all other similar places in Leaflet code and made one more potential fix for
_onRemoveLevel(is not used in Leaflet's core, but available for overriding).