-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Fix exception when calling LayerGroup/hasLayer() with wrong layerId #6998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note: There is even special code in tests to ensure that: Leaflet/spec/suites/layer/LayerGroupSpec.js Lines 2 to 9 in cd12b94
In my opinion it has little sense but can lead to bugs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
That dates back to... wow, #4. My guess is that at some point, the meaning (and documentation) of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The travis CI tests are failing with
77:7 error Identifier 'layer_id' is not in camel case camelcase
78:10 error Identifier 'layer_id' is not in camel case camelcase
Now `false` returned, as per docs
Fixed |
Now
false
returned, as per docsfix #6472