fix(perf): refactor to use htmlparser2 #335
Merged
+121
−208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor to use htmlparser2 which performs parsing in a single pass. This is the same underlying parser used by cheerio.
JustinBeckwith
approved these changes
Oct 5, 2021
|
🎉 This PR is included in version 2.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to use htmlparser2 which performs parsing in a single pass. This is the same underlying parser used by cheerio.
Why?
This significantly increases the performance of parsing, here are the before and after timings for
nodejs-ai-platform(one of our repositories with the largest number of links:)before:
🤖 Successfully scanned 2166 links in 1267.81 seconds.
after:
🤖 Successfully scanned 2166 links in 407.295 seconds.