Skip to content

Commit a1de8e9

Browse files
authoredMar 1, 2022
tests(smoke): enable more devtools smoke tests (#13624)
1 parent 2cef5c9 commit a1de8e9

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed
 

‎.github/workflows/devtools.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -161,9 +161,9 @@ jobs:
161161
- run: mkdir latest-run
162162
working-directory: ${{ github.workspace }}/lighthouse
163163
- name: yarn smoke --runner devtools
164-
# TODO: run on all tests.
165-
# - Current DevTools hangs on any page with a service worker.
166-
# https://github.com/GoogleChrome/lighthouse/issues/13396
167-
# - Various other issues that needed investigation.
168-
run: yarn smoke --runner devtools --shard=${{ matrix.smoke-test-shard }}/${{ strategy.job-total }} --retries=2 --invert-match a11y byte-efficiency byte-gzip dbw errors-expired-ssl errors-infinite-loop lantern-idle-callback-short legacy-javascript metrics-tricky-tti metrics-tricky-tti-late-fcp offline-ready offline-sw-broken offline-sw-slow oopif-requests perf-budgets perf-diagnostics-third-party perf-fonts perf-frame-metrics perf-preload perf-trace-elements pwa redirects-client-paint-server redirects-history-push-state redirects-multiple-server redirects-single-client redirects-single-server screenshot seo-passing seo-tap-targets
164+
# Disabled because normal Chrome usage makes DevTools not function on these poorly constructed pages
165+
# errors-expired-ssl errors-infinite-loop
166+
# Disabled because Chrome will follow the redirect first, and Lighthouse will only ever see/run the final URL.
167+
# redirects-client-paint-server redirects-multiple-server redirects-single-server redirects-single-client
168+
run: yarn smoke --runner devtools --shard=${{ matrix.smoke-test-shard }}/${{ strategy.job-total }} --retries=2 --invert-match a11y byte-efficiency byte-gzip dbw errors-expired-ssl errors-infinite-loop lantern-idle-callback-short legacy-javascript metrics-tricky-tti metrics-tricky-tti-late-fcp oopif-requests perf-budgets perf-diagnostics-third-party perf-fonts perf-frame-metrics perf-preload perf-trace-elements pwa redirects-client-paint-server redirects-history-push-state redirects-multiple-server redirects-single-server redirects-single-client screenshot seo-passing seo-tap-targets
169169
working-directory: ${{ github.workspace }}/lighthouse

0 commit comments

Comments
 (0)
Please sign in to comment.