Chore(build): do not build JS sourcemaps #2432
Merged
+326
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottrippey
commented
Aug 18, 2022
|
I did a spot-check, and the only build difference is the lack of the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We introduced source-map generation to improve Victory development (#2307).
However, we intentionally did not publish these maps to NPM due to excessive file size (several MB).
This PR disables source-maps from the
.jsbuilds. This prevents the//# sourceMappingURL=index.d.ts.mapcomments from being generated and published.This PR does NOT disable
.d.ts.mapgeneration. This allows the developer workflow to stay awesome, since all of our core packages have been converted to TS. (these map files are still not published to NPM)This will address #2346