This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Format baseFeePerGas to number in returned blocks - Closes #4326 #4330
Merged
+58
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Render PR Server URL is https://web3-js-pr-4330.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c517mv1t9ds1hpirptl0. |
nazarhussain
previously approved these changes
Sep 16, 2021
lgtm, also doc update this |
This will be a breaking change. Will need to disseminate information out via community channels before merging. |
jdevcs
suggested changes
Sep 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also update BlockHeader as mentioned by this
jdevcs
previously approved these changes
Sep 22, 2021
nazarhussain
previously approved these changes
Sep 22, 2021
luu-alex
previously approved these changes
Sep 22, 2021
df84c34
Pull Request Test Coverage Report for Build 1263611492
💛 - Coveralls |
jdevcs
approved these changes
Sep 23, 2021
luu-alex
approved these changes
Sep 24, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4326
As mentioned previously, this is technically a breaking change