Skip to content

Commit b741605

Browse files
authoredMay 31, 2023
Fixed label background rendering. (#11293)
* Fixed label background rendering. * Add IKangXu (@IKangXu) to the list of contributors and update changes.md * Update CHANGES.md * Fix background image for label --------- Co-authored-by: IKangXu <xukang@emapgis.com>
1 parent 3906ba3 commit b741605

File tree

3 files changed

+2
-7
lines changed

3 files changed

+2
-7
lines changed
 

‎CHANGES.md

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
- Fixed color creation from CSS color string with modern "space-separated" syntax. [#11271](https://github.com/CesiumGS/cesium/pull/11271)
1010
- Fixed a race condition when loading cut-out terrain. [#11296](https://github.com/CesiumGS/cesium/pull/11296)
1111
- Fixed async behavior for custom terrain and imagery providers. [#11274](https://github.com/CesiumGS/cesium/issues/11274)
12+
- Fixed label background rendering. [#11293](https://github.com/CesiumGS/cesium/pull/11293)
1213

1314
### 1.105.2 - 2023-05-15
1415

‎CONTRIBUTORS.md

+1
Original file line numberDiff line numberDiff line change
@@ -358,3 +358,4 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute to Cesiu
358358
- [Jason Summercamp](https://github.com/fullstacc)
359359
- [Shapovalov Kirill](https://github.com/ShapovalovKL)
360360
- [Alexander Popoff](https://github.com/aerialist7)
361+
- [IKangXu](https://github.com/IKangXu)

‎packages/engine/Source/Scene/Billboard.js

-7
Original file line numberDiff line numberDiff line change
@@ -1169,13 +1169,6 @@ Billboard.prototype._loadImage = function () {
11691169
}
11701170

11711171
if (defined(image)) {
1172-
// No need to wait on imageIndexPromise since these have already been added to the atlas
1173-
const index = atlas.getImageIndex(imageId);
1174-
if (defined(index)) {
1175-
completeImageLoad(index);
1176-
return;
1177-
}
1178-
11791172
imageIndexPromise = atlas.addImage(imageId, image);
11801173
}
11811174
if (defined(imageSubRegion)) {

0 commit comments

Comments
 (0)
Please sign in to comment.