Handle case where Matroska tag target doesn't exist #987
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for sharing the improvement @ws. If you can share a sample demonstrating the issue, I would be interested. Maybe that would allow me to turn it into a unit test. |
|
Part of v7.11.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Ab)using this library to extract tags from MKV files since it's the best Matroska parser I can find. Ran into an edge case where
tag.targetwasn't always present. I was able to fix by tweaking the logic slightly. Not sure you'll ever run into this in music files, but figured I'd open a PR just in case. Cheers!