Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor code improvements in ASF & MPEG parser #1038

Merged
merged 2 commits into from
Feb 27, 2022
Merged

Minor code improvements in ASF & MPEG parser #1038

merged 2 commits into from
Feb 27, 2022
+75 −82

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Feb 26, 2022 •
edited
Loading

Use Uint8Array in favor of Buffer, and covert to Buffer if required, like for text decoding.

@Borewit Borewit self-assigned this Feb 26, 2022
@Borewit Borewit changed the title Minor code improvements in ASF parser Minor code improvements in ASF & MPEG parser Feb 27, 2022
@Borewit Borewit force-pushed the minor-improvement-asf branch 2 times, most recently from 223b150 to b5fa40b Compare February 27, 2022 11:33
@Borewit Borewit added the technical debt Non functional improvements label Feb 27, 2022
@Borewit Borewit force-pushed the minor-improvement-asf branch from b5fa40b to 011cfb0 Compare February 27, 2022 11:40
@Borewit Borewit merged commit 3fcfa39 into master Feb 27, 2022
@Borewit Borewit deleted the minor-improvement-asf branch February 27, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Borewit Borewit

Labels
technical debt Non functional improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Borewit