Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: BenoitZugmeyer/eslint-plugin-html
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f1d3fd69cbcd13e8aa1bb235d7d20098c59f6eff
Choose a base ref
...
head repository: BenoitZugmeyer/eslint-plugin-html
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 12047e752d3f0904541e37ad7ffacde6149e2388
Choose a head ref

Commits on Sep 22, 2018

  1. Copy the full SHA
    e758302 View commit details
  2. Copy the full SHA
    880226e View commit details
  3. Copy the full SHA
    111bd85 View commit details

Commits on Nov 11, 2018

  1. Copy the full SHA
    8706cb1 View commit details
  2. chore: drop support of Node.js 4 from travis

    The plugin tests were executed in Node.js 4, but ESLint 5 does not support
    Node.js 4 anymore, so tests are failing.  Follow the ESLint release and
    drop support from Node.js 4 too.
    BenoitZugmeyer committed Nov 11, 2018
    Copy the full SHA
    d4c44ec View commit details
  3. code cleanup

    BenoitZugmeyer committed Nov 11, 2018
    Copy the full SHA
    84df755 View commit details
  4. improv: drop support for Vue files

    Breaking change.  `eslint-plugin-html` should not be used to lint vue
    files, since the vue puglin is far superior for this usage.
    
    Fixes #103
    BenoitZugmeyer committed Nov 11, 2018
    Copy the full SHA
    8f4bee9 View commit details
  5. Copy the full SHA
    8ab313b View commit details
  6. 5.0.0

    BenoitZugmeyer committed Nov 11, 2018
    Copy the full SHA
    7038332 View commit details

Commits on Feb 1, 2019

  1. Replace undocumented rules.define() with defineRule()

    Christian Kaisermann committed Feb 1, 2019
    Copy the full SHA
    2f3a2b8 View commit details

Commits on Feb 2, 2019

  1. Merge pull request #112 from kaisermann/fix-define-rule

    Replace undocumented rules.define() with defineRule()
    BenoitZugmeyer authored Feb 2, 2019
    Copy the full SHA
    43e31a8 View commit details
  2. Copy the full SHA
    edbd5c2 View commit details
  3. Copy the full SHA
    83dcebc View commit details
  4. 5.0.1

    BenoitZugmeyer committed Feb 2, 2019
    Copy the full SHA
    001c59c View commit details
  5. Copy the full SHA
    0d066d8 View commit details
  6. Copy the full SHA
    389b979 View commit details
  7. 5.0.2

    BenoitZugmeyer committed Feb 2, 2019
    Copy the full SHA
    4f3df94 View commit details
  8. fix: scope sharing should not be influenced by globalReturn: true

    The 'node' environment sets parserOptions.ecmaFeatures.globalReturn to
    'true'.  Because of this, the JS code is considered as wrapped in a
    function, so declared variables are not in the global scope.  To keep
    the configuration simple, scope sharing is only activated by
    parserOptions.sourceType = 'module', so setting globalReturn to true
    should still consider variables declared in the script body to be
    exported to the following scopes.
    Partially fixes #100
    BenoitZugmeyer committed Feb 2, 2019
    Copy the full SHA
    551b01d View commit details
  9. Copy the full SHA
    609869f View commit details
  10. 5.0.3

    BenoitZugmeyer committed Feb 2, 2019
    Copy the full SHA
    402442a View commit details

Commits on May 12, 2019

  1. Copy the full SHA
    ced2723 View commit details
  2. Copy the full SHA
    ae77420 View commit details
  3. 5.0.4

    BenoitZugmeyer committed May 12, 2019
    Copy the full SHA
    080627d View commit details

Commits on May 13, 2019

  1. Copy the full SHA
    877080b View commit details
  2. Copy the full SHA
    9654a51 View commit details
  3. Copy the full SHA
    0121b53 View commit details
  4. 5.0.5

    BenoitZugmeyer committed May 13, 2019
    Copy the full SHA
    bf55745 View commit details

Commits on Jun 26, 2019

  1. fix: eslint v6 support

    BenoitZugmeyer committed Jun 26, 2019
    Copy the full SHA
    b184c8a View commit details
  2. Copy the full SHA
    cf6244b View commit details
  3. Copy the full SHA
    179fc8e View commit details
  4. tests: drop support for Node 6

    ESLint 6 droped the support for Node 6, so tests won't run on it
    anymore.
    BenoitZugmeyer committed Jun 26, 2019
    Copy the full SHA
    290bb1d View commit details
  5. Copy the full SHA
    7ea6ed2 View commit details
  6. 6.0.0

    BenoitZugmeyer committed Jun 26, 2019
    Copy the full SHA
    ad4111d View commit details

Commits on Aug 6, 2019

  1. chore: add logo

    kuceb committed Aug 6, 2019
    Copy the full SHA
    10cdcb9 View commit details
  2. fix readme

    kuceb committed Aug 6, 2019
    Copy the full SHA
    d3ef433 View commit details
  3. Merge pull request #120 from Bkucera/add-logo

    chore: add logo
    BenoitZugmeyer authored Aug 6, 2019
    Copy the full SHA
    864cc68 View commit details
  4. Update README.md

    BenoitZugmeyer authored Aug 6, 2019
    Copy the full SHA
    5458105 View commit details

Commits on Aug 8, 2019

  1. Update README.md

    BenoitZugmeyer authored Aug 8, 2019
    Copy the full SHA
    c008bfe View commit details
  2. Update README.md

    BenoitZugmeyer authored Aug 8, 2019
    Copy the full SHA
    3326159 View commit details

Commits on Nov 30, 2019

  1. Copy the full SHA
    6aba3d0 View commit details

Commits on Apr 4, 2020

  1. Merge pull request #122 from tengattack/patch/doc

    Update README.md and comments
    BenoitZugmeyer authored Apr 4, 2020
    Copy the full SHA
    ff74934 View commit details
  2. Copy the full SHA
    d8c223b View commit details
  3. Copy the full SHA
    c9b66ea View commit details

Commits on Apr 5, 2020

  1. Copy the full SHA
    b9520c7 View commit details
  2. 6.0.1

    BenoitZugmeyer committed Apr 5, 2020
    Copy the full SHA
    38f65bf View commit details

Commits on Apr 15, 2020

  1. Copy the full SHA
    96d02e4 View commit details
  2. Copy the full SHA
    c60ce7d View commit details
  3. 6.0.2

    BenoitZugmeyer committed Apr 15, 2020
    Copy the full SHA
    16e7d7e View commit details

Commits on Apr 21, 2020

  1. Copy the full SHA
    b9476e0 View commit details
  2. Copy the full SHA
    4f2c67a View commit details
3 changes: 3 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -6,3 +6,6 @@ end_of_line = lf
indent_size = 2
indent_style = space
insert_final_newline = true

[src/__tests__/fixtures/crlf-newlines.html]
end_of_line = crlf
16 changes: 16 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
module.exports = {
extends: ["eslint:recommended", "prettier"],

rules: {
"no-constant-condition": "off",
"no-unused-vars": [
"error",
{ varsIgnorePattern: "^_", argsIgnorePattern: "^_" },
],
},

env: {
node: true,
es2018: true,
},
}
12 changes: 0 additions & 12 deletions .eslintrc.yml

This file was deleted.

2 changes: 2 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# ignore test fixtures
src/__tests__/fixtures/* -text
31 changes: 31 additions & 0 deletions .github/ISSUE_TEMPLATE/bug-report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
---
name: Bug report
about: Report a bug or a misbehaviour
---

## Description

<!--
Describe the issue precisely: what are you trying to do? what's the expected result?
-->

## Setup configuration

- ESLint version:
- eslint-plugin-html version:
- NodeJS version:
- Operating System name and version:
- ESLint configuration (.eslintrc):

<!--
If run from an editor plugin:
-->

- Editor name and version:
- Plugin name and version:

## Aditional context

<!--
If you can provide a lock file (package-lock.json, yarn.lock...) or a link to a repository or gist, that would help.
-->
22 changes: 22 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---
name: Feature request
about: Suggest an idea for this project
---

## Description

<!--
A clear and concise description of what the problem is, and what you want to happen. Ex. I'm always frustrated when [...]
-->

## Alternatives

<!--
A clear and concise description of any alternative solutions or features you've considered.
-->

## Additional context

<!--
Add any other context or screenshots about the feature request here.
-->
12 changes: 12 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
version: 2
updates:
- package-ecosystem: npm
directory: "/"
schedule:
interval: weekly
open-pull-requests-limit: 99
- package-ecosystem: github-actions
directory: "/"
schedule:
interval: daily
open-pull-requests-limit: 99
88 changes: 88 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
name: Tests

on:
pull_request:
push:
branches:
- main
schedule:
# Every sunday at midnight
- cron: "0 0 * * 0"

jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
cache: npm
- run: npm ci
- run: npm run lint
- run: npm run format
- run: node tools/toc.js check
- run: npx markdown-link-check -p README.md

integration:
runs-on: ${{ matrix.os }}
needs: lint
strategy:
matrix:
os: [ubuntu-latest]
eslint: ["4.7", latest, next]
include:
# Windows support
- os: windows-latest
eslint: latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
cache: npm
# https://github.com/actions/setup-node/issues/515#issuecomment-1153685437
- if: ${{ matrix.os == 'windows-latest' }}
run: |
$WhereNode = Get-Command node | Select-Object -ExpandProperty Definition
$NodeDirPath = Split-Path $WhereNode -Parent
cd $NodeDirPath
npm install npm@8.12.1
- run: npm ci
- run: bash tools/integration-tests.bash ${{ matrix.eslint }}

test:
runs-on: ${{ matrix.os }}
needs: lint
strategy:
matrix:
os: [ubuntu-latest]
node: [12, 14, 16, 18]
eslint: [latest]
include:
# ESLint 4.7 support: lowest version supported
- os: ubuntu-latest
node: 18
eslint: "4.7"

# ESLint 5 support: lowest version we can use to test external html plugins support
- os: ubuntu-latest
node: 18
eslint: "5.0"

# Upcoming ESLint major version support
- os: ubuntu-latest
node: 18
eslint: next

# Windows support
- os: windows-latest
node: 18
eslint: latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
cache: npm
- run: npm ci
- run: npm install eslint@${{ matrix.eslint }}
- run: npm test
6 changes: 3 additions & 3 deletions .npmignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
/*
!/LICENSE
!/src/
*
!src/*
!CHANGELOG.md
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/src/__tests__/fixtures
9 changes: 0 additions & 9 deletions .travis.yml

This file was deleted.

Loading