Skip to content

Commit c025143

Browse files
jpinksterzbjornson
authored andcommittedJan 9, 2020
Updating Types (#1509)
* Updating Types There are two missing types that I am requesting to add. `jpg` support and on the NodeCanvasRenderingContext2D * Update CHANGELOG.md * fix(typings): Updating available types on construction, update addPage comments
1 parent 98a5141 commit c025143

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed
 

‎CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ project adheres to [Semantic Versioning](http://semver.org/).
1111
### Added
1212
### Fixed
1313
* Fix BMP issues. (#1497)
14+
* Update typings to support jpg and addPage on NodeCanvasRenderingContext2D (#1509)
1415

1516
2.6.1
1617
==================

‎types/index.d.ts

+7-7
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export class Canvas {
7878
/** Constant used in PNG encoding methods. */
7979
readonly PNG_FILTER_PAETH: number
8080

81-
constructor(width: number, height: number, type?: 'pdf'|'svg')
81+
constructor(width: number, height: number, type?: 'image'|'pdf'|'svg')
8282

8383
getContext(contextId: '2d', contextAttributes?: NodeCanvasRenderingContext2DSettings): NodeCanvasRenderingContext2D
8484

@@ -126,12 +126,6 @@ export class Canvas {
126126
toDataURL(mimeType: 'image/jpeg', config: JpegConfig, cb: (err: Error|null, result: string) => void): void
127127
/** _Non-standard._ */
128128
toDataURL(mimeType: 'image/jpeg', quality: number, cb: (err: Error|null, result: string) => void): void
129-
130-
/**
131-
* For PDF canvases, adds another page. If width and/or height are omitted,
132-
* the canvas's initial size is used.
133-
*/
134-
addPage(width?: number, height?: number): void
135129
}
136130

137131
declare class NodeCanvasRenderingContext2D extends CanvasRenderingContext2D {
@@ -212,6 +206,12 @@ declare class NodeCanvasRenderingContext2D extends CanvasRenderingContext2D {
212206
createPattern(...args: any[]): NodeCanvasCanvasPattern
213207
createLinearGradient(x0: number, y0: number, x1: number, y1: number): NodeCanvasCanvasGradient;
214208
createRadialGradient(x0: number, y0: number, r0: number, x1: number, y1: number, r1: number): NodeCanvasCanvasGradient;
209+
210+
/**
211+
* For PDF canvases, adds another page. If width and/or height are omitted,
212+
* the canvas's initial size is used.
213+
*/
214+
addPage(width?: number, height?: number): void
215215
}
216216
export { NodeCanvasRenderingContext2D as CanvasRenderingContext2D }
217217

0 commit comments

Comments
 (0)
Please sign in to comment.