Skip to content

Commit

Permalink
Fix text actualBoundingBoxLeft and actualBoundingBoxRight measures by…
Browse files Browse the repository at this point in the history
… using ink_rect instead of logical_rect
  • Loading branch information
Mickaël Sérégé authored and zbjornson committed Apr 20, 2021
1 parent e4f901c commit 234e659
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/CanvasRenderingContext2d.cc
Expand Up @@ -2698,10 +2698,10 @@ NAN_METHOD(Context2d::MeasureText) {
Nan::New<Number>(logical_rect.width)).Check();
Nan::Set(obj,
Nan::New<String>("actualBoundingBoxLeft").ToLocalChecked(),
Nan::New<Number>(x_offset - PANGO_LBEARING(logical_rect))).Check();
Nan::New<Number>(x_offset - PANGO_LBEARING(ink_rect))).Check();
Nan::Set(obj,
Nan::New<String>("actualBoundingBoxRight").ToLocalChecked(),
Nan::New<Number>(x_offset + PANGO_RBEARING(logical_rect))).Check();
Nan::New<Number>(x_offset + PANGO_RBEARING(ink_rect))).Check();
Nan::Set(obj,
Nan::New<String>("actualBoundingBoxAscent").ToLocalChecked(),
Nan::New<Number>(y_offset + PANGO_ASCENT(ink_rect))).Check();
Expand Down

0 comments on commit 234e659

Please sign in to comment.