Island rhythms/gh 6963 Can overwrite foreignField #12657
Merged
+128
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IslandRhythms
requested review from
vkarpov15 and
hasezoey
and removed request for
vkarpov15
hasezoey
requested changes
Nov 5, 2022
There was a problem hiding this comment.
Some things still need to be done:
- fix the tests (they seem to be consistently failing), the added checks dont check if the previous field is actually defined (see
options) - from what i can tell the options
localFieldandforeignFieldare new topopulate-options and have not been added to the jsdoc or types yet - a
npm run lint --fixwould be good
hasezoey
approved these changes
Nov 7, 2022
vkarpov15
reviewed
Nov 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.