Add support for AbortSignal on eachAsync() #12323
Merged
+51
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdelrahmanHafez
approved these changes
Aug 24, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12173
Summary
Node has support for AbortController and AbortSignal now: https://www.nearform.com/blog/using-abortsignal-in-node-js/ . So we can reasonably easily add support for AbortSignal in a few places, like
eachAsync().The only potential problem with this implementation is that it doesn't actually kill the underlying MongoDB cursor (see https://www.mongodb.com/docs/manual/reference/command/killCursors/ ). However, MongoDB does recommend not killing cursors directly from applications, so this omission is justifiable.
Examples