Merge pull request #12584 from maciasello/fix/gh-11943

fix: (5.x) make access to `process.versions` lazy

Author: vkarpov15

.github/workflows/test.yml

@@ -41,6 +41,8 @@ jobs:
           ln -s `pwd` ./test/typescript/node_modules/mongoose
           echo `pwd`/mongodb-linux-x86_64-ubuntu1804-4.0.2/bin >> $GITHUB_PATH
 
+      - run: npm run build-browser
+
       - run: npm test
 
   lint:

lib/cursor/AggregationCursor.js

@@ -39,7 +39,7 @@ const utils = require('../../lib/utils');
 function AggregationCursor(agg) {
   const streamOpts = { objectMode: true };
   // for node < 12 we will emit 'close' event after 'end'
-  if (utils.nodeMajorVersion >= 12) {
+  if (utils.nodeMajorVersion() >= 12) {
     // set autoDestroy=true because on node 12 it's by default false
     // gh-10902 need autoDestroy to destroy correctly and emit 'close' event for node >= 12
     streamOpts.autoDestroy = true;
@@ -95,7 +95,7 @@ AggregationCursor.prototype._read = function() {
           return _this.emit('error', error);
         }
         // for node >= 12 the autoDestroy will emit the 'close' event
-        if (utils.nodeMajorVersion < 12) {
+        if (utils.nodeMajorVersion() < 12) {
           _this.on('end', () => _this.emit('close'));
         }
       });

lib/cursor/QueryCursor.js

@@ -37,7 +37,7 @@ const utils = require('../../lib/utils');
 function QueryCursor(query, options) {
   const streamOpts = { objectMode: true };
   // for node < 12 we will emit 'close' event after 'end'
-  if (utils.nodeMajorVersion >= 12) {
+  if (utils.nodeMajorVersion() >= 12) {
     // set autoDestroy=true because on node 12 it's by default false
     // gh-10902 need autoDestroy to destroy correctly and emit 'close' event for node >= 12
     streamOpts.autoDestroy = true;
@@ -104,7 +104,7 @@ QueryCursor.prototype._read = function() {
           return _this.emit('error', error);
         }
         // for node >= 12 the autoDestroy will emit the 'close' event
-        if (utils.nodeMajorVersion < 12) {
+        if (utils.nodeMajorVersion() < 12) {
           _this.on('end', () => _this.emit('close'));
         }
       });

lib/utils.js

@@ -936,4 +936,6 @@ exports.errorToPOJO = function errorToPOJO(error) {
   return ret;
 };
 
-exports.nodeMajorVersion = parseInt(process.versions.node.split('.')[0], 10);
+exports.nodeMajorVersion = function nodeMajorVersion() {
+  return parseInt(process.versions.node.split('.')[0], 10);
+};

test/browser.test.js

@@ -4,6 +4,8 @@
  * Module dependencies.
  */
 
+require('../lib/browser');
+
 const Document = require('../lib/browserDocument');
 const Schema = require('../lib/schema');
 const assert = require('assert');
@@ -18,6 +20,10 @@ describe('browser', function() {
     exec('node --eval "require(\'./lib/browser\')"', done);
   });
 
+  it('require() works in an environment where process.versions is an empty object (gh-5842)', function(done) {
+    exec('node --eval "Object.defineProperty(process, \'versions\', { value: {} }); require(\'./dist/browser.umd\')"', done);
+  });
+
   it('using schema (gh-7170)', function(done) {
     exec('node --eval "const mongoose = require(\'./lib/browser\'); new mongoose.Schema();"', done);
   });